Skip to content

Lets MakeResponse(Route) explicitly call MakeResponse(ManyRoutes) in RouteAPI#4057

Merged
daniel-j-h merged 1 commit intomasterfrom
route-api-make-response
May 18, 2017
Merged

Lets MakeResponse(Route) explicitly call MakeResponse(ManyRoutes) in RouteAPI#4057
daniel-j-h merged 1 commit intomasterfrom
route-api-make-response

Conversation

@daniel-j-h
Copy link
Copy Markdown
Member

@daniel-j-h daniel-j-h force-pushed the route-api-make-response branch from 834eb61 to 78c3bef Compare May 17, 2017 15:47
@daniel-j-h
Copy link
Copy Markdown
Member Author

@oxidase
Copy link
Copy Markdown
Contributor

oxidase commented May 17, 2017

nice, it hits the note

[ Note: This is intended to allow compiler transformations such as removal of empty loops, even when
termination cannot be proven. — end note ]

@danpat
Copy link
Copy Markdown
Member

danpat commented May 17, 2017

Yeah. I think we avoided the problem through the following mechanism:

  1. Compiler optimized away MakeResponse(Route)
  2. Calls that would've matched MakeResponse(Route) were instead redirected to MakeResponse(ManyRoutes) because it can cast Route->ManyRoutes

While this works, it's definitely a bit black-magicy, removing this weird function is 👍

@daniel-j-h daniel-j-h merged commit 403db7c into master May 18, 2017
@daniel-j-h daniel-j-h deleted the route-api-make-response branch May 18, 2017 08:54
@daniel-j-h
Copy link
Copy Markdown
Member Author

Follow up from chat: AppVeyor build was 🍏 looks like a spurious error:
https://ci.appveyor.com/project/DennisOSRM/osrm-backend/build/1.0.8186

Also: after meging this into master Travis also had a spurious failure:
https://travis-ci.org/Project-OSRM/osrm-backend/jobs/233549233

where we were unable to download Clang, silently continued the build, used the system's pre-installed Clang 3.5 and then errored during compilation.

[Mason] Downloading package https://mason-binaries.s3.amazonaws.com/linux-x86_64/clang++/4.0.0.tar.gz...
CMake Error at cmake/mason.cmake:80 (message):
[Mason] Failed to download  https://mason-binaries.s3.amazonaws.com/linux-x86_64/clang++/4.0.0.tar.gz:
curl: (56) SSL read: error:00000000:lib(0):func(0):reason(0), errno 104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants