Conversation
Member
|
@oxidase good idea. 👍 What about adding this to one of the Travis jobs, too? |
a7076c7 to
0650835
Compare
Contributor
Author
|
Rebased and added the check to the /cc @MoKob |
TheMarex
reviewed
Dec 13, 2016
Member
TheMarex
left a comment
There was a problem hiding this comment.
I'm not sure we need the option in the cmake as we could also just conditionally call make check-headers from travis.
CMakeLists.txt
Outdated
| endif() | ||
| list(APPEND sources ${filename}) | ||
| endforeach() | ||
| add_library(check-headers STATIC EXCLUDE_FROM_ALL ${sources}) |
Member
There was a problem hiding this comment.
This is excluded by default from the ALL target, why do we need an additional option?
Contributor
Author
There was a problem hiding this comment.
removed, makes no sense. Just wanted to double check that it will not be included in all
0650835 to
ca77e6a
Compare
Contributor
Author
|
@TheMarex removed ENABLE_HEADERS_CHECK option and added a conditional check in .travis.yml |
047be9a to
1c63a93
Compare
1c63a93 to
b1aced3
Compare
Contributor
Author
|
Updated PR:
|
3 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Added a simple check for headers consistency. It creates a set of cpp files that only include hpp files and
make check-headerswill show incorrect header files. It will not work for files with duplicated names.Tasklist
Code Review Checklist - author check these when done, reviewer verify
scripts/format.shIf something doesn't apply, please
cross it outRequirements / Relations
Link any requirements here. Other pull requests this PR is based on?