make sure to not-collapse different travel modes#2877
Merged
Conversation
|
|
||
| When I route I should get | ||
| | waypoints | route | turns | | ||
| | k,j | on,ferry,,ferry,off,off | depart,new name straight,continue uturn,turn straight,new name straight,arrive | |
Member
There was a problem hiding this comment.
The new name straight comes from the ferry way? To be honest I expected a notification here.
Author
There was a problem hiding this comment.
Yeah. Thats something we have to improve on. It's a shortcoming from getInstructionForObvious. But thats a different issue (in the process of opening it)
MoKob
force-pushed
the
fix/collapse-same-modes
branch
from
9437413 to
749bab1
Compare
| else if (isCollapsableInstruction(current_step.maneuver.instruction) && | ||
| current_step.maneuver.instruction.type != TurnType::Suppressed && | ||
| steps[getPreviousNameIndex(step_index)].name_id == current_step.name_id && | ||
| // canCollapseAll is also checking for compatible turns |
Member
There was a problem hiding this comment.
What do you mean by this? compatible checks the travel mode, but what do you mean with compatible turns? from one travel mode to another I suppose?
Author
There was a problem hiding this comment.
I am referring to the function compatible by name. I can also say steps if that is less confusing.
MoKob
force-pushed
the
fix/collapse-same-modes
branch
from
749bab1 to
c306a59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
resolves #2876
Tasklist