Via way restrictions [WIP]#1828
Closed
rparanjpe-tesla wants to merge 4 commits intoProject-OSRM:developfrom
Closed
Via way restrictions [WIP]#1828rparanjpe-tesla wants to merge 4 commits intoProject-OSRM:developfrom
rparanjpe-tesla wants to merge 4 commits intoProject-OSRM:developfrom
Conversation
Member
|
@rparanjpe-tesla The approach seems sound. Only concern seems the nearest neighbor search. Currently we assume that the nearest neighbor is unique - in the case of overlapping segments it obviously wouldn't be the case. As a result we might snap to (b') instead of (b) if we start a search on that segment and won't find a path to (c). |
Member
|
Please reopen the PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a branch under development to incorporate via way restrictions, currently with the 'no_' case with a 3-member restriction (from, via, to).
This will work as follows:
a->b->c.restrictionsfile along with the regular restrictions in a special format (documented in the code)Concretely, let's say we have three ways in the restriction:
a->b->c(ais the from,bis the via,cis the to). We create a new edge based node (b') and take all of the outgoing edge_based_edges ofband duplicate them so thatb'also has those outgoing edges. Next we delete the edge_based_edge connectingatoband create an identically weighted one fromatob'. Finally we delete the edge fromb'toc.I'll be adding commits to this branch, but would love feedback as I continue development.
@TheMarex @danpat