-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
skip_waypoints ignored in node bindings #6059
Copy link
Copy link
Closed
Description
I'm trying to implement skip_waypoints as an option my Node API, but the parameter has no effect. My C++ is beyond rusty, but I believe the issue is that include/nodejs/node_osrm_support.hpp does not include this in the argumentsToParameter function.
I'm happy to submit a pull request for this, essentially duplicating the "generate_hints" block from lines 662:676, replacing generate_hints with skip_waypoints. However, I lack the skills to determine if this is a sufficient fix. Can anyone provide guidance?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels