Skip to content

skip_waypoints ignored in node bindings #6059

@maciejb

Description

@maciejb

I'm trying to implement skip_waypoints as an option my Node API, but the parameter has no effect. My C++ is beyond rusty, but I believe the issue is that include/nodejs/node_osrm_support.hpp does not include this in the argumentsToParameter function.

I'm happy to submit a pull request for this, essentially duplicating the "generate_hints" block from lines 662:676, replacing generate_hints with skip_waypoints. However, I lack the skills to determine if this is a sufficient fix. Can anyone provide guidance?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions