Skip to content

Update acceleration tutorials for MetaTensor#786

Merged
wyli merged 7 commits intoProject-MONAI:mainfrom
yuchen-xu:782-acceleration-metatensor
Jul 16, 2022
Merged

Update acceleration tutorials for MetaTensor#786
wyli merged 7 commits intoProject-MONAI:mainfrom
yuchen-xu:782-acceleration-metatensor

Conversation

@yuchen-xu
Copy link
Copy Markdown
Contributor

@yuchen-xu yuchen-xu commented Jul 14, 2022

Fixes #782 .

Status

Work in progress

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

@review-notebook-app
Copy link
Copy Markdown

review-notebook-app bot commented Jul 14, 2022

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@yuchen-xu yuchen-xu self-assigned this Jul 14, 2022
@yuchen-xu yuchen-xu mentioned this pull request Jul 14, 2022
Merged
@yuchen-xu yuchen-xu force-pushed the 782-acceleration-metatensor branch from 8956d19 to 5983bbb Compare July 16, 2022 01:44
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Jul 16, 2022

Hi @yuchen-xu ,

Did you see any performance drop in the fast training pipeline when you switched from 0.9.0 to 0.9.1?

Thanks.

@yuchen-xu
Copy link
Copy Markdown
Contributor Author

yuchen-xu commented Jul 16, 2022

@Nic-Ma Thanks a lot for the suggestion. I tried it and here's what I got:
0.9.1rc3 Original: 314.19s Optimized: 21.78s
0.9.0 Original: 278.79s Optimized: 13.00s

@yuchen-xu yuchen-xu marked this pull request as ready for review July 16, 2022 02:54
@yuchen-xu yuchen-xu requested review from Nic-Ma and wyli July 16, 2022 02:54
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Jul 16, 2022

Hi @wyli ,

Seems 0.9.1rc3 is much slower, especially for the optimized pipeline?

Thanks.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jul 16, 2022

yes I've addressed some deepcopy issues in Project-MONAI/MONAI#4709, will tag a new release candidate for testing. this PR looks good.

@wyli wyli changed the title [WIP] Update acceleration tutorials for MetaTensor Update acceleration tutorials for MetaTensor Jul 16, 2022
@wyli wyli merged commit 6863062 into Project-MONAI:main Jul 16, 2022
@yuchen-xu yuchen-xu mentioned this pull request Jul 18, 2022
Merged
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Jul 19, 2022

I tested the training speed on V100 with MONAI 0.9.0 and latest dev (after 0.9.1rc3):
average speed of 1 epoch: 0.9.0=1.74s, dev=1.8s
Maybe we can continue to optimize MetaTensor operations in the future versions.

Thanks.

@wyli wyli mentioned this pull request Jul 25, 2022
Merged
7 tasks
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
@yuchen-xu
Update acceleration tutorials for MetaTensor (Project-MONAI#786)
8fa7a08 
* updated AMP tutorial for 0.9.1rc2

* updated for 0.9.1rc2 compatibility

* modification done, pending final checks

* tests run on 0.9.1rc3, ready for review

* updated for 0.9.1rc3

Co-authored-by: Yuchen Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees

@yuchen-xu yuchen-xu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update acceleration tutorials for MetaTensor

3 participants

@yuchen-xu @Nic-Ma @wyli