Skip to content

245 Update tutorials with new API (part 2)#253

Merged
wyli merged 15 commits intomasterfrom
245-update-with-new-api-part2
Jul 12, 2021
Merged

245 Update tutorials with new API (part 2)#253
wyli merged 15 commits intomasterfrom
245-update-with-new-api-part2

Conversation

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Jul 7, 2021 •
edited
Loading

Signed-off-by: Yiheng Wang [email protected]

Partially fixes #245 .

Description

This PR modifies the remnant examples in modules (as mentioned in #246 ).

Status

Ready

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

@yiheng-wang-nv
update with new api
6ddf656 
Signed-off-by: Yiheng Wang <[email protected]>
@review-notebook-app
Copy link
Copy Markdown

review-notebook-app bot commented Jul 7, 2021

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@yiheng-wang-nv
fix pep8 lr
146159a 
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv yiheng-wang-nv requested a review from Nic-Ma July 7, 2021 15:04
@yiheng-wang-nv
Copy link
Copy Markdown
Contributor Author

yiheng-wang-nv commented Jul 7, 2021 •
edited
Loading

Hi @SachidanandAlle , could you please help to update the deepgrow/ignite/handler.py (https://github.com/Project-MONAI/tutorials/blob/master/deepgrow/ignite/handler.py) to meet the decollate changes? Thanks!

@SachidanandAlle
Copy link
Copy Markdown
Contributor

SachidanandAlle commented Jul 7, 2021

I suggest we discontinue this Handler.. Developer can use existing ones to write dice and dump images..

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor Author

yiheng-wang-nv commented Jul 7, 2021 •
edited
Loading

I suggest we discontinue this Handler.. Developer can use existing ones to write dice and dump images..

Do you mean remove the file handler.py? Or could you please help to update the tutorial directly?

@SachidanandAlle
Copy link
Copy Markdown
Contributor

SachidanandAlle commented Jul 7, 2021

Yes..

@yiheng-wang-nv yiheng-wang-nv mentioned this pull request Jul 8, 2021
Merged
1 task
Nic-Ma
Nic-Ma reviewed Jul 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update, I put some comments inline.
Others look good to me.

Thanks.

Nic-Ma
Nic-Ma approved these changes Jul 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.
Looks good to me now.
@wyli could you please help double confirm it?

Thanks in advance.

@Nic-Ma Nic-Ma requested a review from wyli July 12, 2021 10:17
wyli
wyli approved these changes Jul 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@wyli wyli merged commit 70ac974 into master Jul 12, 2021
@wyli wyli deleted the 245-update-with-new-api-part2 branch July 12, 2021 12:47
@wyli wyli mentioned this pull request Jul 12, 2021
Closed
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
@yiheng-wang-nv
245 Update tutorials with new API (part 2) (Project-MONAI#253)
8eda715 
* update with new api

Signed-off-by: Yiheng Wang <[email protected]>

* fix pep8 lr

Signed-off-by: Yiheng Wang <[email protected]>

* fix format error

Signed-off-by: Yiheng Wang <[email protected]>

* update with decollate

Signed-off-by: Yiheng Wang <[email protected]>

* replace to use 0.6.0

Signed-off-by: Yiheng Wang <[email protected]>

* update inverse example

Signed-off-by: Yiheng Wang <[email protected]>

* update transfer mmar

Signed-off-by: Yiheng Wang <[email protected]>

* update with new api for jupyter_utils.ipynb

Signed-off-by: Yiheng Wang <[email protected]>

* fix pep8

Signed-off-by: Yiheng Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Nic-Ma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update all the examples & notebooks to use new APIs

4 participants

@yiheng-wang-nv @SachidanandAlle @wyli @Nic-Ma