Skip to content

Video seg#213

Merged
wyli merged 21 commits intoProject-MONAI:mainfrom
rijobro:video_seg
Aug 16, 2022
Merged

Video seg#213
wyli merged 21 commits intoProject-MONAI:mainfrom
rijobro:video_seg

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented May 24, 2021

Description

Adds an initial video training notebook.

This tutorial is simplistic in that each of the frames is treated as being completely independent. At the end, the frames are compiled into videos to allow for video inference, see here for an example of the inference executable (python and C++).

Status

Ready

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rijobro rijobro force-pushed the video_seg branch 2 times, most recently from 82a6eaa to 0d645c0 Compare July 29, 2022 14:51
@rijobro rijobro marked this pull request as ready for review July 29, 2022 14:53
@rijobro rijobro requested review from Nic-Ma and wyli July 29, 2022 14:53
@binliunls
Copy link
Copy Markdown
Contributor

binliunls commented Aug 1, 2022

Hi @rijobro , I got three suggestions and was not sure about if they are helpful. Maybe we can discuss about them.
1, In this part of the video dataset, I think you transfer a bgr image to rgb one implicitly. Could it be better if a parameter like "color_type", default as "rgb", are given and used to decide whether the image channel should be changed.
https://github.com/rijobro/MONAI/blob/c3fd10aeda4bf488f98ad2850c12978fa85e1f42/monai/data/video_dataset.py#L56
2, In the "video_seg.ipynb" tutorial, would it be helpful if the training dataloader's "shuffle" parameter were set to "True"?
3, The timing part in "video_seg.ipynb" may not work when cuda device involved,since cuda is a asynchronous process. The link below is a reference on how to do it.
https://pytorch.org/TensorRT/_notebooks/EfficientNet-example.html

@rijobro rijobro mentioned this pull request Aug 5, 2022
2 tasks
@rijobro
Copy link
Copy Markdown
Contributor Author

rijobro commented Aug 5, 2022

@binliunls Changes have been incorporated.

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Aug 8, 2022

Depends on the Video dataset PR in MONAI.

Thanks.

@wyli wyli enabled auto-merge (squash) August 16, 2022 21:58
@wyli wyli merged commit e7d810b into Project-MONAI:main Aug 16, 2022
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
* video seg

* update video seg tutorial

* remove jit comparison

* move to cpu before jit save

* sort imports

* changes

* changes

* changes

* final

* fixes

* final changes

* move get_available_codecs into class

* skipping test

Signed-off-by: Wenqi Li <[email protected]>

Signed-off-by: Wenqi Li <[email protected]>
Co-authored-by: Wenqi Li <[email protected]>
Co-authored-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants