Skip to content

[144][145] fail fast and pattern#148

Merged
wyli merged 2 commits intoProject-MONAI:masterfrom
rijobro:failfast_and_pattern
Mar 22, 2021
Merged

[144][145] fail fast and pattern#148
wyli merged 2 commits intoProject-MONAI:masterfrom
rijobro:failfast_and_pattern

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented Mar 22, 2021

fixes #144
fixes #145

To test:

./runner.sh -p "read|load"

Gives output

Files to be tested:
./acceleration/threadbuffer_performance.ipynb
./modules/load_medical_images.ipynb
./modules/nifti_read_example.ipynb

Then break a file, e.g., add import foo to ./modules/load_medical_images.ipynb.

With -f, script stops straight away, otherwise continues.

@rijobro rijobro requested a review from wyli March 22, 2021 14:55
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit 9b5e9d5 into Project-MONAI:master Mar 22, 2021
@rijobro rijobro deleted the failfast_and_pattern branch April 1, 2021 10:53
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
* fail fast and pattern

* updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support of skipping notebook tests (testing script) support of not failfast (testing script)

2 participants