Skip to content

remove the draft version of the GDSDataset#1473

Merged
wyli merged 2 commits intoProject-MONAI:mainfrom
KumoLiu:update-gdsdataset
Jul 28, 2023
Merged

remove the draft version of the GDSDataset#1473
wyli merged 2 commits intoProject-MONAI:mainfrom
KumoLiu:update-gdsdataset

Conversation

@KumoLiu
Copy link
Copy Markdown
Contributor

@KumoLiu KumoLiu commented Jul 27, 2023

Description

  • After Add GDSdataset MONAI#6778, GDSDataset has been added in core, remove the draft version in the tutorial.
  • Update the result based on the new version

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Signed-off-by: KumoLiu <[email protected]>
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@KumoLiu KumoLiu marked this pull request as ready for review July 27, 2023 08:14
@KumoLiu KumoLiu requested review from Nic-Ma, ericspod and wyli July 27, 2023 09:23
@wyli wyli merged commit ddf61ab into Project-MONAI:main Jul 28, 2023
@KumoLiu KumoLiu deleted the update-gdsdataset branch August 3, 2023 03:28
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
### Description
- After Project-MONAI/MONAI#6778, `GDSDataset`
has been added in core, remove the draft version in the tutorial.
- Update the result based on the new version

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Avoid including large-size files in the PR.
- [x] Clean up long text outputs from code cells in the notebook.
- [ ] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

Signed-off-by: KumoLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants