replace to use native clip norm#221
Merged
mingxin-zheng merged 2 commits intoProject-MONAI:mainfrom Apr 18, 2023
Merged
Conversation
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
it's also used here |
Signed-off-by: Wenqi Li <[email protected]>
mingxin-zheng
approved these changes
Apr 18, 2023
Contributor
mingxin-zheng
left a comment
mingxin-zheng
left a comment
There was a problem hiding this comment.
Thank you @wyli !
Two comments:
- This will fix another issue that
apexis missing for conda users who installed through https://github.com/Project-MONAI/MONAI/blob/dev/requirements-dev.txt - The issue is already fixed in
apex, but I guess the PyTorch container doesn't use the latest version: NVIDIA/apex@6943fd2
7 tasks
wyli
added a commit
to Project-MONAI/MONAI
that referenced
this pull request
Apr 18, 2023
Fixes #6378 . ### Description - Project-MONAI/research-contributions#221 - Project-MONAI/research-contributions#219 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Mingxin Zheng <[email protected]> Signed-off-by: Wenqi Li <[email protected]> Co-authored-by: Wenqi Li <[email protected]> Co-authored-by: Wenqi Li <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes Project-MONAI/MONAI#6378
will this work @dongyang0122 ?