Skip to content

Update segresnet2D with a function to check if skip#213

Merged
heyufan1995 merged 5 commits intoProject-MONAI:mainfrom
heyufan1995:monai-rc
Apr 10, 2023
Merged

Update segresnet2D with a function to check if skip#213
heyufan1995 merged 5 commits intoProject-MONAI:mainfrom
heyufan1995:monai-rc

Conversation

@heyufan1995
Copy link
Copy Markdown
Member

@heyufan1995 heyufan1995 commented Mar 26, 2023

No description provided.

mingxin-zheng
mingxin-zheng reviewed Mar 27, 2023
View reviewed changes
mingxin-zheng
mingxin-zheng reviewed Mar 27, 2023
View reviewed changes
myron
myron reviewed Mar 27, 2023
View reviewed changes
@heyufan1995 heyufan1995 merged commit de5a8d1 into Project-MONAI:main Apr 10, 2023
@mingxin-zheng
Copy link
Copy Markdown
Contributor

mingxin-zheng commented Apr 11, 2023 •
edited
Loading

@heyufan1995
Sorry please ignore the following message. I think it is a PR in MONAI that's breaking these local tests.

This commit is breaking the tests:

root@adminn-MS-7D31:/workspace/monai/research-contributions# python auto3dseg/tests/test_algo_templates.py
File ./tmp_sim_work_dir/datastats.yaml already exists and will be overwritten.
100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 12/12 [00:00<00:00, 35.06it/s]
2023-04-11 14:26:45,483 - INFO - segresnet2d_0 is skipped! 2D network is skipped due to median spacing of [1.0, 1.0, 1.0].
2023-04-11 14:26:45,532 - INFO - ./tmp_sim_work_dir/dints_0
Loaded self.data_list_file ./tmp_sim_work_dir/input.yaml
2023-04-11 14:26:45,555 - INFO - ./tmp_sim_work_dir/segresnet_0
2023-04-11 14:26:45,598 - INFO - ./tmp_sim_work_dir/swinunetr_0
100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 12/12 [00:00<00:00, 15.65it/s]
2023-04-11 14:26:47,475 - INFO - segresnet2d_0 is skipped! 2D network is skipped due to median spacing of [1.0, 1.0, 1.0].
2023-04-11 14:26:47,524 - INFO - ./tmp_sim_work_dir/dints_0
Loaded self.data_list_file ./tmp_sim_work_dir/input.yaml
2023-04-11 14:26:47,546 - INFO - ./tmp_sim_work_dir/segresnet_0
2023-04-11 14:26:47,587 - INFO - ./tmp_sim_work_dir/swinunetr_0
100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 12/12 [00:00<00:00, 63.94it/s]
2023-04-11 14:26:47,926 - INFO - segresnet2d_0 is skipped! 2D network is skipped due to median spacing of [1.0, 1.0, 1.0].
2023-04-11 14:26:47,976 - INFO - ./tmp_sim_work_dir/dints_0
Loaded self.data_list_file ./tmp_sim_work_dir/input.yaml
2023-04-11 14:26:47,998 - INFO - ./tmp_sim_work_dir/segresnet_0
2023-04-11 14:26:48,039 - INFO - ./tmp_sim_work_dir/swinunetr_0
E
======================================================================
ERROR: test_sim_0 (__main__.TestAlgoTemplates)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/parameterized/parameterized.py", line 533, in standalone_func
    return func(*(a + p.args), **p.kwargs)
  File "auto3dseg/tests/test_algo_templates.py", line 164, in test_sim
    preds = auto_run(work_dir, data_src_cfg, self.algos)
  File "auto3dseg/tests/test_algo_templates.py", line 128, in auto_run
    algo.train(train_param)
AttributeError: 'str' object has no attribute 'train'

======================================================================
ERROR: test_sim_1 (__main__.TestAlgoTemplates)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/parameterized/parameterized.py", line 533, in standalone_func
    return func(*(a + p.args), **p.kwargs)
  File "auto3dseg/tests/test_algo_templates.py", line 164, in test_sim
    preds = auto_run(work_dir, data_src_cfg, self.algos)
  File "auto3dseg/tests/test_algo_templates.py", line 128, in auto_run
    algo.train(train_param)
AttributeError: 'str' object has no attribute 'train'

======================================================================
ERROR: test_sim_2 (__main__.TestAlgoTemplates)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/parameterized/parameterized.py", line 533, in standalone_func
    return func(*(a + p.args), **p.kwargs)
  File "auto3dseg/tests/test_algo_templates.py", line 164, in test_sim
    preds = auto_run(work_dir, data_src_cfg, self.algos)
  File "auto3dseg/tests/test_algo_templates.py", line 128, in auto_run
    algo.train(train_param)
AttributeError: 'str' object has no attribute 'train'

----------------------------------------------------------------------
Ran 3 tests in 3.050s

@mingxin-zheng mingxin-zheng mentioned this pull request Apr 12, 2023
Merged
2 tasks
wyli pushed a commit to Project-MONAI/MONAI that referenced this pull request Apr 12, 2023
@mingxin-zheng
Update AlGO_HASH (#6346)
76ad1b6 
Fixes #6247  .

### Description

It includes two changes:
- Project-MONAI/research-contributions#218
- Project-MONAI/research-contributions#213

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [x] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.

Signed-off-by: Mingxin Zheng <[email protected]>
@wyli wyli mentioned this pull request Apr 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myron myron myron left review comments

@mingxin-zheng mingxin-zheng mingxin-zheng left review comments

@dongyang0122 dongyang0122 Awaiting requested review from dongyang0122

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heyufan1995 @mingxin-zheng @myron