Merged
Conversation
Signed-off-by: Mingxin Zheng <[email protected]>
dongyang0122
reviewed
Jan 6, 2023
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
2 tasks
wyli
pushed a commit
to Project-MONAI/MONAI
that referenced
this pull request
Mar 15, 2023
Signed-off-by: Mingxin Zheng <[email protected]> Fixes #5972 . ### Description Fix and New Feature included: - fix cache rate: Project-MONAI/research-contributions#173 - typo fix Project-MONAI/research-contributions#178 - scheduler step fix Project-MONAI/research-contributions#182 - enhancement Project-MONAI/research-contributions#184 - Fixed pretrain weight loading Project-MONAI/research-contributions#202 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] `python tests/test_integration_autorunner.py` succeeded locally --------- Signed-off-by: Mingxin Zheng <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #172
Signed-off-by: Mingxin Zheng [email protected]
Dints in Auto3DSeg has an override function
trainthat first search and then train. Previously, alltrain_paramoverride, such asnum_epochs, will be passed to the search and train functions with additional key prefix:searching#andtraining#, because these hyperparameters are undersearchingandtraininginhyper_parameter_search.ymlandhyper_parameter.yml, respectively.This PR fixes an issue that user cannot pass an override if the parameter is not under
searchingortrainingin those config files. The PR will add the prefix only if the override key can be found undersearchinginhyper_parameter_search.ymlandtraininginhyper_parameter.yml. For example,cache_rateis not either undersearchingortraining. So the function won't addsearching#ortraining#in the override process and the param can be correctly set insearchandtrain.This will also fix if the user wants to override other params in the root level.