Skip to content

fix cache_rate#173

Merged
dongyang0122 merged 6 commits intoProject-MONAI:mainfrom
mingxin-zheng:fix-172
Jan 27, 2023
Merged

fix cache_rate#173
dongyang0122 merged 6 commits intoProject-MONAI:mainfrom
mingxin-zheng:fix-172

Conversation

@mingxin-zheng
Copy link
Copy Markdown
Contributor

@mingxin-zheng mingxin-zheng commented Dec 30, 2022

Fix #172
Signed-off-by: Mingxin Zheng [email protected]

Dints in Auto3DSeg has an override function train that first search and then train. Previously, all train_param override, such as num_epochs, will be passed to the search and train functions with additional key prefix: searching# and training#, because these hyperparameters are under searching and training in hyper_parameter_search.yml and hyper_parameter.yml, respectively.

This PR fixes an issue that user cannot pass an override if the parameter is not under searching or training in those config files. The PR will add the prefix only if the override key can be found under searching in hyper_parameter_search.yml and training in hyper_parameter.yml. For example, cache_rate is not either under searching or training. So the function won't add searching# or training# in the override process and the param can be correctly set in search and train.

This will also fix if the user wants to override other params in the root level.

@dongyang0122 dongyang0122 merged commit ec53a15 into Project-MONAI:main Jan 27, 2023
wyli pushed a commit to Project-MONAI/MONAI that referenced this pull request Mar 15, 2023
Signed-off-by: Mingxin Zheng
<[email protected]>

Fixes #5972 .

### Description
Fix and New Feature included:
- fix cache rate:
Project-MONAI/research-contributions#173
- typo fix
Project-MONAI/research-contributions#178
- scheduler step fix
Project-MONAI/research-contributions#182
- enhancement
Project-MONAI/research-contributions#184
- Fixed pretrain weight loading
Project-MONAI/research-contributions#202

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [x] `python tests/test_integration_autorunner.py` succeeded locally

---------

Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng mingxin-zheng deleted the fix-172 branch March 27, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot override cache_rate for Auto3DSeg DiNTS

2 participants