[part 2] Update all bundles to Huggingface and fix missing dependencies#743
Merged
yiheng-wang-nv merged 6 commits intoProject-MONAI:devfrom Apr 9, 2025
Conversation
Signed-off-by: Yiheng Wang <[email protected]>
Collaborator
Author
|
/build |
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Collaborator
Author
|
/build |
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Collaborator
Author
|
/build |
There was a problem hiding this comment.
Copilot reviewed 3 out of 22 changed files in this pull request and generated no comments.
Files not reviewed (19)
- ci/run_premerge_cpu.sh: Language not supported
- ci/run_premerge_gpu.sh: Language not supported
- models/pancreas_ct_dints_segmentation/configs/metadata.json: Language not supported
- models/pathology_nuclei_classification/configs/metadata.json: Language not supported
- models/pathology_nuclei_segmentation_classification/configs/metadata.json: Language not supported
- models/pathology_nuclick_annotation/configs/metadata.json: Language not supported
- models/pathology_tumor_detection/configs/metadata.json: Language not supported
- models/pediatric_abdominal_ct_segmentation/configs/metadata.json: Language not supported
- models/prostate_mri_anatomy/configs/metadata.json: Language not supported
- models/renalStructures_CECT_segmentation/configs/metadata.json: Language not supported
- models/renalStructures_UNEST_segmentation/configs/metadata.json: Language not supported
- models/segmentation_template/configs/metadata.json: Language not supported
- models/spleen_ct_segmentation/configs/metadata.json: Language not supported
- models/spleen_deepedit_annotation/configs/metadata.json: Language not supported
- models/swin_unetr_btcv_segmentation/configs/metadata.json: Language not supported
- models/valve_landmarks/configs/metadata.json: Language not supported
- models/ventricular_short_axis_3label/configs/metadata.json: Language not supported
- models/vista2d/configs/metadata.json: Language not supported
- models/vista3d/configs/metadata.json: Language not supported
Comments suppressed due to low confidence (2)
ci/get_bundle_requirements.py:21
- Removing the special-case declaration for 'xformers' may result in its dependency being added without the necessary conditional logic. Please verify that this change aligns with the intended dependency management for bundles.
SPECIAL_LIB_LIST = ["xformers"]
ci/get_bundle_requirements.py:81
- The removal of special-case logic that filtered out 'xformers' and conditionally excluded 'torch' may lead to unexpected dependency conflicts. Confirm that this simplified logic is safe in all bundle scenarios.
for name, version in optional_dict.items():
Collaborator
Author
|
KumoLiu
reviewed
Apr 9, 2025
KumoLiu
reviewed
Apr 9, 2025
KumoLiu
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #739 .
Description
A few sentences describing the changes proposed in this pull request.
Status
Ready
Please ensure all the checkboxes:
./runtests.sh --codeformat.versionandchangeloginmetadata.jsonif changing an existing bundle.CONTRIBUTING.md).monai,pytorchandnumpyare correct inmetadata.json.eval_metricsof the provided weights and TorchScript modules.large_file.yml./home/your_name/for"bundle_root").