Migrate Brain Image Synthesis Latent Diffusion from GenerativeModels to model-zoo#722
Merged
ericspod merged 44 commits intoProject-MONAI:devfrom Feb 6, 2025
Merged
Conversation
…s repo. Signed-off-by: Virginia <[email protected]>
… that no longer applies.
… longer necessary. On inference, modification of the entry point from save_jpg to run to allow for run to be called alone, and truncation of loading statements which are too long. Modification of the README to include command example changes.
For metadata, adjusted the versions, setting current to Initial Release. I also removed nibabel from the optional package requirements as this CXR produces JPG and does not deal with nifti files.
…erify_bundle to pass the check for model.pt, since the requirement for two models (autoencoder and diffusion_model) makes sense for them to keep their specific names. Modification of inference.json to add dummy attributes to pass the ConfigWorkflow check. Modification of large_files.yml so that models are .pt and not .pth.
…erify_bundle to pass the check for model.pt, since the requirement for two models (autoencoder and diffusion_model) makes sense for them to keep their specific names. Modification of inference.json to add dummy attributes to pass the ConfigWorkflow check. Modification of large_files.yml so that models are .pt and not .pth.
Add LICENSE file.
Modification of diffusion_model.pt name to model.pt to go through the verify_bundle Python function.
Contributor
Collaborator
|
/build |
KumoLiu
reviewed
Jan 21, 2025
Collaborator
KumoLiu
left a comment
KumoLiu
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Leave several comments inline.
models/brain_image_synthesis_latent_diffusion_model/configs/inference.json
Outdated
Show resolved
Hide resolved
models/brain_image_synthesis_latent_diffusion_model/docs/README.md
Outdated
Show resolved
Hide resolved
models/brain_image_synthesis_latent_diffusion_model/configs/metadata.json
Outdated
Show resolved
Hide resolved
models/brain_image_synthesis_latent_diffusion_model/configs/inference.json
Outdated
Show resolved
Hide resolved
models/brain_image_synthesis_latent_diffusion_model/scripts/saver.py
Outdated
Show resolved
Hide resolved
Contributor
Author
? |
Collaborator
|
/build |
Collaborator
|
FYI @garciadias, error from blossom. |
Collaborator
|
/build |
Collaborator
|
Hi @garciadias , "/build" is used to trigger the CI pipeline, this PR looks good to me, and if all tests passed, I will merge it. Thanks! |
Contributor
Author
Hi @yiheng-wang-nv, thank you for explaining and reviewing this. I believe I fixed all the issues pointed out in the CI checks. I noticed the Many thanks! |
ericspod
reviewed
Jan 27, 2025
models/brain_image_synthesis_latent_diffusion_model/configs/metadata.json
Outdated
Show resolved
Hide resolved
…tadata.json Co-authored-by: Eric Kerfoot <[email protected]> Signed-off-by: Rafael Garcia-Dias <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
…is' into brain_image_synthesis
Collaborator
|
/build |
Collaborator
|
Signed-off-by: Eric Kerfoot <[email protected]>
Collaborator
|
/build |
Signed-off-by: Eric Kerfoot <[email protected]>
ericspod
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # No issue assigned
Description
This is part of the effort on deprecating GenerativeModels and having all models available in the model-zoo instead.
Status
Ready
Please ensure all the checkboxes:
./runtests.sh --codeformat.versionandchangeloginmetadata.jsonif changing an existing bundle.CONTRIBUTING.md).monai,pytorchandnumpyare correct inmetadata.json.eval_metricsof the provided weights and TorchScript modules.large_file.yml./home/your_name/for"bundle_root").