180 Update several bundles into monai 1.0.1#187
Merged
yiheng-wang-nv merged 5 commits intodevfrom Nov 8, 2022
Merged
Conversation
Nic-Ma
approved these changes
Nov 8, 2022
Collaborator
Author
|
/build |
…ject-MONAI/model-zoo into 180-update-several-bundles-for-1.0.1
Collaborator
Author
|
/build |
1 similar comment
Collaborator
Author
|
/build |
This was referenced Nov 9, 2022
yiheng-wang-nv
added a commit
to yiheng-wang-nv/model-zoo
that referenced
this pull request
Jul 29, 2024
Fixes Project-MONAI#180 and Project-MONAI#186 ### Description This PR follows Project-MONAI#179 and Project-MONAI#182 to update some of the remanent bundles into monai 1.0.1 version: `endoscopic_inbody_classification` and `endoscopic_tool_segmentation` are verified by @binliunls , `spleen_deepedit_annotation`, `pancreas_ct_dints_segmentation` are verified by myself. `lung_nodule_ct_detection` is updated without detailed check due to the size of the dataset. For `pathology_tumor_detection`, as mentioned in: Project-MONAI/MONAI#5485 in order to match monai 1.0.1, this bundle is adjusted to not support torchscript. ### Status **Ready** ### Please ensure all the checkboxes: <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Codeformat tests passed locally by running `./runtests.sh --codeformat`. - [ ] In-line docstrings updated. - [ ] Update `version` and `changelog` in `metadata.json` if changing an existing bundle. - [ ] Please ensure the naming rules in config files meet our requirements (please refer to: `CONTRIBUTING.md`). - [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy` are correct in `metadata.json`. - [ ] Descriptions should be consistent with the content, such as `eval_metrics` of the provided weights and TorchScript modules. - [ ] Files larger than 25MB are excluded and replaced by providing download links in `large_file.yml`. - [ ] Avoid using path that contains personal information within config files (such as use `/home/your_name/` for `"bundle_root"`). Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #180 and #186
Description
This PR follows #179 and #182 to update some of the remanent bundles into monai 1.0.1 version:
endoscopic_inbody_classificationandendoscopic_tool_segmentationare verified by @binliunls ,spleen_deepedit_annotation,pancreas_ct_dints_segmentationare verified by myself.lung_nodule_ct_detectionis updated without detailed check due to the size of the dataset.For
pathology_tumor_detection, as mentioned in: Project-MONAI/MONAI#5485 in order to match monai 1.0.1, this bundle is adjusted to not support torchscript.Status
Ready
Please ensure all the checkboxes:
./runtests.sh --codeformat.versionandchangeloginmetadata.jsonif changing an existing bundle.CONTRIBUTING.md).monai,pytorchandnumpyare correct inmetadata.json.eval_metricsof the provided weights and TorchScript modules.large_file.yml./home/your_name/for"bundle_root").