10 Update workflow for automatic upload bundle#11
Conversation
…oject-MONAI/model-zoo into 10-enhance-workflow-for-update-models
|
So far, the auto steps include:
Then, an admin/contributor is able to create a new pull request of this created new branch (this create pr is still manual, I tried to add Another place that to be added is the uploading results check, since the upload thing may fail due to network or other issues, I will address this part later. |
|
looks like a permission issue you can try name: Push to master
on:
push:
branches:
- master
jobs:
build:
runs-on: ubuntu-latest
steps:
# the checkout action persists the passed credentials by default
# subsequent git commands will pick them up automatically
- uses: actions/checkout@v2
with:
token: ${{secrets.PAT}}
- run: |
# do something
git push |
|
Thanks @wyli , the push part is fine, and the issue comes from the auto pull request part. I used |
Signed-off-by: Yiheng Wang <[email protected]>
|
Hi @Nic-Ma
The next step is to put it into a workflow. |
|
Hi @yiheng-wang-nv , Great improvement, please hold on for the workflow, maybe let's put it into Blossom directly. Thanks. |
|
I see you commented much code in this PR, those parts are not ready to use? Thanks. |
|
Hi @wyli @Nic-Ma and @ericspod , I just marked the status of this PR into "Ready", and could you please help to review it? During a previous commit, I used the spleen ct segmentation bundle for test: log, uploaded place, produced new branch |
|
thanks, this looks great, does this support deletion as well? just wanted to confirm that if I submit a PR to permanently remove a bundle folder, the PR won't break the pipeline. And I guess we should provide some instructions to the users/admins about how to remove a bundle folder. |
|
Hi @wyli , That's a good corner case, @yiheng-wang-nv please make sure a PR can delete some bundles in the source code(not in the release storage). Thanks. |
|
The version strings are part of the compressed file's names so we should mention in the specification that versions should follow semantic versioning and contain only characters valid in filenames. |
Thanks! @wyli and @Nic-Ma . If delete a whole bundle, according to the logic ( |
wyli
left a comment
There was a problem hiding this comment.
looks good to me, a minor point -- requirements.txt could be updated
Co-authored-by: Wenqi Li <[email protected]>
Hi @ericspod , I created a small PR for it: Project-MONAI/MONAI#4512, could you please help review it? Thanks in advance. |
* update workflow * remove test print and run cmd * update git config in update * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * run git config at first * fix flake8 * add prompt enter * remove the pr part * set back to merge workflow * use zip method * enable manual trigger * remove lfs in workflow to check quota * uncomment upload * fix black * check lfs in workflow * add check pr changed files yml * update download and upload release Signed-off-by: Yiheng Wang <[email protected]> * fix format issue and comment workflows * handle errors * fix flake8 error * change large file name * test update spleen * fix format error * change error message and use monai 0.9.0rc2 * change requirements * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix issue * fix flake8 error * raise error if update wrong * update workflow with push new commit * update requirements and test with spleen * remove extra lfs * add check status for push commit * add push error message * fix error naming * remove duplicate try raise * remove update model token * revert test part for formal usage * update delete case and clean rmtree code * fix codeformat issue * update readme about how to remove a bundle * Update requirements.txt Co-authored-by: Wenqi Li <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Wenqi Li <[email protected]>
Fixes #10 .
Description
This PR is used to add the automatic uploading actions after a PR is merged. The workflow is like:

Status
Ready
Please ensure all the checkboxes:
./runtests.sh --codeformat.