Skip to content

Fix shapely dep + girder client#745

Merged
SachidanandAlle merged 7 commits intomainfrom
dep_fixes
Apr 13, 2022
Merged

Fix shapely dep + girder client#745
SachidanandAlle merged 7 commits intomainfrom
dep_fixes

Conversation

@SachidanandAlle
Copy link
Copy Markdown
Collaborator

Signed-off-by: Sachidanand Alle [email protected]

@jamesobutler
Copy link
Copy Markdown
Contributor

SimpleITK version 2.1.1.1 is required for Python 3.10 whl while version 2.1.1 used for other python version whl. Even though 2.1.1.1 is yanked on PyPI, you can get the python 3.10 whl files if you specify the version directly. This was recommended by the SimpleITK developers until there is a 2.1.1.2 which contains whl for all python versions.

SimpleITK==2.1.1.1; python_version == '3.10'
SimpleITK>=2.1.1

Signed-off-by: Sachidanand Alle <[email protected]>
Signed-off-by: Sachidanand Alle <[email protected]>
@SachidanandAlle
Copy link
Copy Markdown
Collaborator Author

As expected: https://github.com/Project-MONAI/MONAILabel/runs/6007917497?check_suite_focus=true

ERROR: Could not find a version that satisfies the requirement itk>=5.2; extra == "itk" (from monai[gdown,ignite,itk,lmdb,nibabel,openslide,pillow,psutil,skimage,tensorboard,torchvision,tqdm]) (from versions: 4.12.0.post1, 4.13.0, 4.13.1.post1, 5.0a1, 5.0a2, 5.0b1, 5.0b3, 5.0rc1, 5.0rc2, 5.0.0, 5.0.0.post1, 5.0.1, 5.3rc2, 5.3rc2.post1, 5.3rc3, 5.3rc4)
ERROR: No matching distribution found for itk>=5.2; extra == "itk"

As I recommend, lets wait until monai gives green flag for python 3.10 support..

Signed-off-by: Sachidanand Alle <[email protected]>
@jamesobutler
Copy link
Copy Markdown
Contributor

Can you add the ci check for Python 3.7 as well as that is still supported by MonaiLabel?

MONAILabel/setup.cfg

Lines 18 to 19 in c9c8451

[options]
python_requires = >= 3.7

Signed-off-by: Sachidanand Alle <[email protected]>
@SachidanandAlle SachidanandAlle added the 0.4.0 Targeted to Release version 0.4 label Apr 13, 2022
@SachidanandAlle SachidanandAlle merged commit 80ff4a4 into main Apr 13, 2022
@SachidanandAlle SachidanandAlle deleted the dep_fixes branch April 13, 2022 14:48
Douwe-Spaanderman pushed a commit to Douwe-Spaanderman/MONAILabel that referenced this pull request Dec 9, 2022
* Fix shapely dep + girder client

Signed-off-by: Sachidanand Alle <[email protected]>

* CI check for dep on windows/ubuntu

Signed-off-by: Sachidanand Alle <[email protected]>

* support only 3.8 and 3.9 versions

Signed-off-by: Sachidanand Alle <[email protected]>

* support < 3.10 versions

Signed-off-by: Sachidanand Alle <[email protected]>

* ci check for 3.10

Signed-off-by: Sachidanand Alle <[email protected]>

* ci check only 3.8 and 3.9 versions

Signed-off-by: Sachidanand Alle <[email protected]>

* ci check for 3.7

Signed-off-by: Sachidanand Alle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.4.0 Targeted to Release version 0.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unsuccessful pip install monailabel>=0.4.0rc2 on Windows platform with Python 3.10

2 participants