Show/hide tabs based on models that are available#693
Merged
diazandr3s merged 2 commits intomainfrom Mar 15, 2022
Merged
Conversation
Signed-off-by: Sachidanand Alle <[email protected]>
SachidanandAlle
added this to the
3D Slicer Public Server Instance using MONAI Label [p0] milestone
diazandr3s
approved these changes
Mar 15, 2022
jlvahldiek
reviewed
May 5, 2022
Comment on lines
+498
to
+501
| if self.info.get("trainers", {}): | ||
| self.ui.aclCollapsibleButton.show() | ||
| else: | ||
| self.ui.aclCollapsibleButton.hide() |
Contributor
There was a problem hiding this comment.
@SachidanandAlle, we are running two segmentation apps that do not make use of any trainers.
With these code changes our workflow of using MONAILabel to segment images from scratch or to use pre-segmentations does not work any more because the buttons 'Next Sample' and 'Submit Sample' are not available any more.
I can understand the rationale behind these code changes but for our use case it doesn't work. Is it possible to discuss these code changes? Thanks.
Collaborator
Author
There was a problem hiding this comment.
You are correct.. it was a bug.. we should only hide training part and not fetch/submit actions..
this PR should solve the problem.. #769
Contributor
There was a problem hiding this comment.
Thanks a lot for the quick fix.
Douwe-Spaanderman
pushed a commit
to Douwe-Spaanderman/MONAILabel
that referenced
this pull request
Dec 9, 2022
Signed-off-by: Sachidanand Alle <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sachidanand Alle [email protected]