Allow ApplyTransformToPointsd receive a sequence of refer keys#8063
Merged
KumoLiu merged 14 commits intoProject-MONAI:devfrom Sep 4, 2024
Merged
Allow ApplyTransformToPointsd receive a sequence of refer keys#8063KumoLiu merged 14 commits intoProject-MONAI:devfrom
KumoLiu merged 14 commits intoProject-MONAI:devfrom
Conversation
Contributor
Author
|
refer to the use case here: https://github.com/Project-MONAI/tutorials/blob/main/3d_registration/learn2reg_nlst_paired_lung_ct.ipynb |
KumoLiu
requested review from
Nic-Ma,
atbenmurray,
ericspod,
mingxin-zheng and
vikashg
ericspod
reviewed
Sep 2, 2024
ericspod
reviewed
Sep 2, 2024
ericspod
reviewed
Sep 2, 2024
Co-authored-by: Eric Kerfoot <[email protected]> Signed-off-by: YunLiu <[email protected]>
Co-authored-by: Eric Kerfoot <[email protected]> Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
ericspod
reviewed
Sep 3, 2024
ericspod
approved these changes
Sep 3, 2024
Member
ericspod
left a comment
ericspod
left a comment
There was a problem hiding this comment.
I had a minor point on tests but otherwise it looks good.
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Contributor
Author
|
/build |
Signed-off-by: YunLiu <[email protected]>
vikashg
reviewed
Sep 3, 2024
Signed-off-by: YunLiu <[email protected]>
Contributor
Author
|
/build |
Contributor
Author
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance
ApplyTransformToPointsdto receive a sequence of refer keys.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.