Add vista3d inferers by heyufan1995 · Pull Request #8021 · Project-MONAI/MONAI

heyufan1995 · 2024-08-15T15:20:55Z

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

Non-breaking change (fix or new feature that would not break existing functionality).
Breaking change (fix or new feature that would cause existing functionality to change).
New tests added to cover the changes.
Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
In-line docstrings updated.
Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: heyufan1995 <[email protected]>

for more information, see https://pre-commit.ci

monai/inferers/utils.py

monai/networks/nets/vista3d.py

monai/apps/vista3d/inferer.py

Signed-off-by: Yiheng Wang <[email protected]>

monai/apps/vista3d/inferer.py

Signed-off-by: Yiheng Wang <[email protected]>

tests/test_point_based_window_inferer.py

Signed-off-by: Yiheng Wang <[email protected]>

monai/apps/vista3d/transforms.py

Signed-off-by: Yiheng Wang <[email protected]>

Signed-off-by: heyufan1995 <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: heyufan1995 <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: heyufan1995 <[email protected]>

monai/apps/vista3d/__init__.py

Signed-off-by: Yiheng Wang <[email protected]>

for more information, see https://pre-commit.ci

monai/apps/vista3d/inferer.py

monai/apps/vista3d/transforms.py

monai/inferers/utils.py

monai/apps/vista3d/inferer.py

Signed-off-by: heyufan1995 <[email protected]>

…I into add-vista3d-other-utils

for more information, see https://pre-commit.ci

Signed-off-by: heyufan1995 <[email protected]>

…I into add-vista3d-other-utils

for more information, see https://pre-commit.ci

mingxin-zheng

Thanks for fixing the docstrings! I don't have other suggestions on this PR.

Signed-off-by: Yiheng Wang <[email protected]>

KumoLiu · 2024-08-21T03:36:14Z

/build

Signed-off-by: heyufan1995 <[email protected]>

for more information, see https://pre-commit.ci

monai/apps/vista3d/workflow.py

Signed-off-by: Yiheng Wang <[email protected]>

monai/apps/vista3d/sampler.py

Signed-off-by: Yiheng Wang <[email protected]>

Signed-off-by: heyufan1995 <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: Yiheng Wang <[email protected]>

KumoLiu · 2024-08-23T05:29:17Z

/build

KumoLiu · 2024-08-23T06:39:00Z

/build

KumoLiu · 2024-08-23T08:02:23Z

[2024-08-23T07:19:14.039Z] ======================================================================
[2024-08-23T07:19:14.039Z] ERROR: test_result_0 (tests.test_vista3d_transforms.TestVistaPostTransformd)
[2024-08-23T07:19:14.039Z] ----------------------------------------------------------------------
[2024-08-23T07:19:14.039Z] Traceback (most recent call last):
[2024-08-23T07:19:14.039Z]   File "/usr/local/lib/python3.9/dist-packages/parameterized/parameterized.py", line 620, in standalone_func
[2024-08-23T07:19:14.039Z]     return func(*(a + p.args), **p.kwargs, **kw)
[2024-08-23T07:19:14.039Z]   File "/home/jenkins/agent/workspace/MONAI-premerge/monai/tests/test_vista3d_transforms.py", line 89, in test_result
[2024-08-23T07:19:14.039Z]     result = transform(input_data)
[2024-08-23T07:19:14.039Z]   File "/home/jenkins/agent/workspace/MONAI-premerge/monai/monai/apps/vista3d/transforms.py", line 170, in __call__
[2024-08-23T07:19:14.039Z]     pred[pred == frac] = data["label_prompt"][i - 1].to(pred.dtype)
[2024-08-23T07:19:14.039Z] RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu!
[2024-08-23T07:19:14.039Z] 
[2024-08-23T07:19:14.039Z] ----------------------------------------------------------------------
[2024-08-23T07:19:14.039Z] Ran 15586 tests in 1326.707s

mingxin-zheng

The PR looks good to me, and only had a minor comment below. Thanks!

monai/apps/vista3d/inferer.py

KumoLiu · 2024-08-26T02:56:40Z

Hi @heyufan1995 and @yiheng-wang-nv, could you please help take a look at this ci error and also address @mingxin-zheng's comments, then I can trigger more tests and merge the PR. Thanks.

Signed-off-by: Yiheng Wang <[email protected]>

KumoLiu · 2024-08-26T03:31:24Z

/build

Add vista3d inferers

cae979a

Signed-off-by: heyufan1995 <[email protected]>

heyufan1995 requested review from KumoLiu and yiheng-wang-nv August 15, 2024 15:20

[pre-commit.ci] auto fixes from pre-commit.com hooks

daf7b45

for more information, see https://pre-commit.ci