Merged
Conversation
Signed-off-by: heyufan1995 <[email protected]>
ericspod
reviewed
Aug 2, 2024
ericspod
reviewed
Aug 2, 2024
ericspod
reviewed
Aug 2, 2024
ericspod
reviewed
Aug 2, 2024
ericspod
reviewed
Aug 2, 2024
ericspod
reviewed
Aug 2, 2024
ericspod
reviewed
Aug 2, 2024
ericspod
reviewed
Aug 2, 2024
ericspod
reviewed
Aug 2, 2024
Member
|
Hi @heyufan1995 Thanks for the contribution from the VISTA team! I've added a few comments on style and such to try improving readability and number of lines. We will also need unit tests for anything added. You can also run the auto formatting fixes with |
KumoLiu
reviewed
Aug 5, 2024
Contributor
|
HI @heyufan1995 , I suggest we split this PR into three small PRs:
To merge int MONAI, there are some basic requirements:
It would be more efficient to handle each parts separately |
Signed-off-by: Yufan He <[email protected]>
This was referenced Aug 6, 2024
Merged
Merged
Contributor
for utils functions, I copy the content and submit a draft PR: #7999 |
yiheng-wang-nv
added a commit
that referenced
this pull request
Aug 7, 2024
Fixes #7994 . ### Description The current implementation does not support tuple input of "GEGLU" since it only change the out features of the first linear layer when the input is a string of "GEGLU". This PR enhances it, and also enable "vista3d" mode to support #7987 Tests are added to cover the changes. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Yiheng Wang <[email protected]> Signed-off-by: YunLiu <[email protected]> Co-authored-by: YunLiu <[email protected]>
Contributor
|
other discussed topics:
|
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: heyufan1995 <[email protected]>
…to add-vista3d-network
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
KumoLiu
reviewed
Aug 13, 2024
Co-authored-by: YunLiu <[email protected]> Signed-off-by: Yiheng Wang <[email protected]>
KumoLiu
reviewed
Aug 13, 2024
Signed-off-by: heyufan1995 <[email protected]>
KumoLiu
approved these changes
Aug 14, 2024
Contributor
KumoLiu
left a comment
KumoLiu
left a comment
There was a problem hiding this comment.
Thanks for the quick update, LGTM now.
Contributor
Signed-off-by: Yiheng Wang <[email protected]>
Contributor
|
/build |
rcremese
pushed a commit
to rcremese/MONAI
that referenced
this pull request
Sep 2, 2024
This PR is a part of Project-MONAI#7987 ### Description A few sentences describing the changes proposed in this pull request. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Yiheng Wang <[email protected]> Signed-off-by: YunLiu <[email protected]> Signed-off-by: Yiheng Wang <[email protected]> Co-authored-by: YunLiu <[email protected]> Co-authored-by: Eric Kerfoot <[email protected]>
rcremese
pushed a commit
to rcremese/MONAI
that referenced
this pull request
Sep 2, 2024
Fixes # . ### Description Add VISTA3D model architecture to MONAI core ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: heyufan1995 <[email protected]> Signed-off-by: Yufan He <[email protected]> Signed-off-by: Yiheng Wang <[email protected]> Signed-off-by: Yiheng Wang <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yiheng Wang <[email protected]> Co-authored-by: Yiheng Wang <[email protected]> Co-authored-by: YunLiu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
Add VISTA3D model architecture to MONAI core
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.