Hi @Can-Zhao , do you think it would be too much work to make this a general transform?

I think erode/dilate is general medical image operations, which may be used elsewhere. So making this a general utility function or transform may be helpful.

Hi @Can-Zhao , do you think it would be too much work to make this a general transform?

I think erode/dilate is general medical image operations, which may be used elsewhere. So making this a general utility function or transform may be helpful.

It's a good idea, but maybe not in this PR...

It's a good idea, but maybe not in this PR...

Okay, we can make these functions in generation today, and in the future, move the implementation to transforms and use the transform in these functions.

Hi @Can-Zhao, please help take a look at the format issue: https://github.com/Project-MONAI/MONAI/actions/runs/9754160317/job/26920608008?pr=7893#step:7:387. Thanks!

@KumoLiu Have you met this error? File "/workspace/MONAI/monai/utils/misc.py", line 27, in
from distutils.util import strtobool
ModuleNotFoundError: No module named 'distutils'

@KumoLiu Have you met this error? File "/workspace/MONAI/monai/utils/misc.py", line 27, in from distutils.util import strtobool ModuleNotFoundError: No module named 'distutils'

Nevermind, forgot I should do "pip install --upgrade --force-reinstall setuptools"

Hi @Can-Zhao, please take a look at the ci error: https://github.com/Project-MONAI/MONAI/actions/runs/9755561869/job/26924281793?pr=7893#step:13:19908
Thanks.

Hi @Can-Zhao, please take a look at the ci error: https://github.com/Project-MONAI/MONAI/actions/runs/9755561869/job/26924281793?pr=7893#step:13:19908 Thanks.

I'm confused why it cannot import the func. As python -m tests.test_morphological_ops is runnable on my machine. Nevertheless, I changed the way to import. If not working, I will need your help.

@Nic-Ma @KumoLiu These erode and dilate functions are used in both Vista and MAISI. I was wondering if we should move it to somewhere else. If so, which folder would be a good choice? Or we may leave it here for now?

@Nic-Ma @KumoLiu These erode and dilate functions are used in both Vista and MAISI. I was wondering if we should move it to somewhere else. If so, which folder would be a good choice? Or we may leave it here for now?

We can leave it here for now. And as @mingxin-zheng said, when we refactored it to inherit Transform next time, we can move it under transforms folder.
cc @Nic-Ma @ericspod @mingxin-zheng

@Nic-Ma @KumoLiu These erode and dilate functions are used in both Vista and MAISI. I was wondering if we should move it to somewhere else. If so, which folder would be a good choice? Or we may leave it here for now?

We can leave it here for now. And as @mingxin-zheng said, when we refactored it to inherit Transform next time, we can move it under transforms folder. cc @Nic-Ma @ericspod @mingxin-zheng

Cool! Then it seems this PR can be merged after passing the tests. Thanks!

/build