785 add test program for CUDA extension#786
785 add test program for CUDA extension#786Nic-Ma merged 22 commits intoProject-MONAI:masterfrom Nic-Ma:785-add-cuda-test-program
Conversation
|
I tried to compile this CUDA extension in MONAI docker directly, it completed successfully. Thanks. |
|
/black |
|
/black |
|
some mypy issue here? |
Yes, now I updated according to the latest tutorial code. |
|
I feel this feature is an important and unique one, shall we make it a top-level module, such as |
|
could you help remove this temporary file, I think it is included by mistake: https://github.com/Project-MONAI/MONAI/blob/master/tests/testing_data/._Task04_Hippocampus |
Sure, will remove it in the next commit. |
|
/black |
|
@Nic-Ma progress so far:
to resolve 1: looks like we need to address option b properly additionally, there's a mypy issue... |
|
Hi @wyli , Thanks very much for your help! |
|
Hi @wyli , Thanks very much for your help here, I think it looks good to me now. |
|
this is ready @Nic-Ma (delayed because I wanted to add some pip install cache so that the CI tests are slightly more robust) |
OK, sounds good! |
Fixes #785 .
Description
This PR adapted from PyTorch C++ extension example: https://pytorch.org/tutorials/advanced/cpp_extension.html
Quickly summarise the progress made so far by this PR:
as an initial step of testing/packaging/distributing cuda kernels in monai, it addresses
runtests.shupdates for c++/cuda extensions supportpython setup.py developto compile the extensions (this is only a workaround as it ignores bothpyproject.toml'sbuild-systemand pep517things that are not covered by this PR:
Status
ready
Types of changes
./runtests.sh --codeformat --coverage.make htmlcommand in thedocs/folder.