Skip to content

Add LICENSE requirement in spec#7014

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
KumoLiu:bundle-license
Sep 25, 2023
Merged

Add LICENSE requirement in spec#7014
wyli merged 2 commits intoProject-MONAI:devfrom
KumoLiu:bundle-license

Conversation

@KumoLiu
Copy link
Copy Markdown
Contributor

@KumoLiu KumoLiu commented Sep 20, 2023

Fixes #6964.

Description

Add LICENSE requirement in specification.
https://github.com/Project-MONAI/model-zoo/blob/bdd183ebc113a70d50db4e4fb2ebd9a7c8c7532b/ci/verify_bundle.py#L28

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested a review from ericspod September 20, 2023 09:19
@KumoLiu KumoLiu marked this pull request as ready for review September 20, 2023 09:53
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve according to licensee/licensee#335, feel free to revisit this if there are further concerns.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Sep 25, 2023

/build

@wyli wyli enabled auto-merge (squash) September 25, 2023 08:32
@wyli wyli merged commit cc3faa3 into Project-MONAI:dev Sep 25, 2023
@KumoLiu KumoLiu deleted the bundle-license branch September 26, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

init_bundle Should Put License File in docs

3 participants