Skip to content

6676 port generative metrics#6836

Merged
wyli merged 18 commits intoProject-MONAI:devfrom
marksgraham:6676_port_generative_metrics
Aug 16, 2023
Merged

6676 port generative metrics#6836
wyli merged 18 commits intoProject-MONAI:devfrom
marksgraham:6676_port_generative_metrics

Conversation

@marksgraham
Copy link
Copy Markdown
Contributor

@marksgraham marksgraham commented Aug 8, 2023 •
edited
Loading

Work towards addressing #6676. Ports all metrics to MONAI.

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli
wyli approved these changes Aug 10, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me, just a minor comment inline, cc @mingxin-zheng please help confirm the PR

marksgraham and others added 2 commits August 11, 2023 04:42
@marksgraham @wyli
Update monai/metrics/fid.py
3c81128 
Co-authored-by: Wenqi Li <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
@marksgraham
Update docs
78cc8cc 
Signed-off-by: Mark Graham <[email protected]>
mingxin-zheng
mingxin-zheng reviewed Aug 11, 2023
View reviewed changes
mingxin-zheng
mingxin-zheng reviewed Aug 11, 2023
View reviewed changes
mingxin-zheng
mingxin-zheng reviewed Aug 11, 2023
View reviewed changes
mingxin-zheng
mingxin-zheng reviewed Aug 11, 2023
View reviewed changes
@marksgraham marksgraham marked this pull request as ready for review August 15, 2023 14:22
@marksgraham
Make variables lowercase
a5cdba9 
Signed-off-by: Mark Graham <[email protected]>
@marksgraham
Fix variable name
20de356 
Signed-off-by: Mark Graham <[email protected]>
@wyli wyli requested a review from mingxin-zheng August 16, 2023 12:16
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Aug 16, 2023

/build

@wyli wyli merged commit 9ae72e4 into Project-MONAI:dev Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danieltudosiu danieltudosiu danieltudosiu left review comments

@wyli wyli wyli approved these changes

@mingxin-zheng mingxin-zheng Awaiting requested review from mingxin-zheng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marksgraham @wyli @danieltudosiu @mingxin-zheng