Make template_path in BundleAlgo consistently point to the algorithm_templates folder#6505
Merged
wyli merged 3 commits intoProject-MONAI:devfrom May 10, 2023
mingxin-zheng:fix-6502-nni
Merged
Make template_path in BundleAlgo consistently point to the algorithm_templates folder#6505wyli merged 3 commits intoProject-MONAI:devfrom mingxin-zheng:fix-6502-nni
wyli merged 3 commits intoProject-MONAI:devfrom
mingxin-zheng:fix-6502-nni
Conversation
Signed-off-by: Mingxin <[email protected]>
Signed-off-by: Mingxin <[email protected]>
Signed-off-by: Mingxin <[email protected]>
Contributor
|
/integration-test |
wyli
approved these changes
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6502
Fixes #6501
Background
template_pathpoints toalgorithm_templates/<Algo><= MONAI 1.1. Recent PR Make Auto3DSeg algo able to find algorithm templates #6436 changed that toalgorithm_templatesand make it easier to instantiate the BundleAlgo from "algorithm_templates" folder when the folders are moved.BundleGendid not update accordingly and still savealgorithm_templates/<Algo>as thetemplate_path, which breaks NNI HPO feature which relies heavily on these paths.Description
template_pathpoints toalgorithm_templatesfilelock(3.12.0) which breaks nniTypes of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.