Skip to content

Make template_path in BundleAlgo consistently point to the algorithm_templates folder#6505

Merged
wyli merged 3 commits intoProject-MONAI:devfrom
mingxin-zheng:fix-6502-nni
May 10, 2023
Merged

Make template_path in BundleAlgo consistently point to the algorithm_templates folder#6505
wyli merged 3 commits intoProject-MONAI:devfrom
mingxin-zheng:fix-6502-nni

Conversation

@mingxin-zheng
Copy link
Copy Markdown
Contributor

@mingxin-zheng mingxin-zheng commented May 10, 2023

Fixes #6502
Fixes #6501

Background

  • BundleAlgo template_path points to algorithm_templates/<Algo> <= MONAI 1.1. Recent PR Make Auto3DSeg algo able to find algorithm templates #6436 changed that to algorithm_templates and make it easier to instantiate the BundleAlgo from "algorithm_templates" folder when the folders are moved.
  • But BundleGen did not update accordingly and still save algorithm_templates/<Algo> as the template_path , which breaks NNI HPO feature which relies heavily on these paths.

Description

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 10, 2023

/integration-test
/build

@wyli wyli enabled auto-merge (squash) May 10, 2023 11:39
@wyli wyli disabled auto-merge May 10, 2023 11:49
@wyli wyli enabled auto-merge (squash) May 10, 2023 11:49
@wyli wyli merged commit d3e9826 into Project-MONAI:dev May 10, 2023
@mingxin-zheng mingxin-zheng deleted the fix-6502-nni branch March 27, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto3DSeg HPO folder structure error in 1.2.0rc6 Auto3DSeg HPO with nni 'SimplePreemptiveLock' object has no attribute '_lock_file'

2 participants