Auto3dseg ensemble path fix#6481
Merged
wyli merged 1 commit intoProject-MONAI:devfrom May 6, 2023
myron:ensem
Merged
Conversation
Signed-off-by: myron <[email protected]>
wyli
reviewed
May 6, 2023
wyli
approved these changes
May 6, 2023
Contributor
|
/build |
wyli
added a commit
that referenced
this pull request
May 6, 2023
7 tasks
wyli
pushed a commit
that referenced
this pull request
May 7, 2023
redo #6481 . ### Description - Take the code from #6481 - Deprecate `data_src_cfg_filename` and replace it with `data_src_cfg_name` so that the same thing can be consistent across AutoRunner, BundleGen, and Ensemble classes - Make `data_src_cfg_name` a required argument in the ensemble runner because it is prone to error to use a default name. - Improves test structure, but nothing major is changed. What is not done: - Add tests to check the output structure, because EnsembleRunner doesn't support changing the pred_param for individual algo seperately, and then I can't really run the `ensemble` method in EnsembleRunner. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Mingxin Zheng <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto3dseg ensembling saves output results to the same filename if input images had the same name (but in different folders). this PR maintains the folder structure, so that the outputs are in different folders.
Description
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.