Skip to content

Auto3DSeg ensemble tests images depend on #GPUs + docstring improvement#6457

Merged
wyli merged 8 commits intoProject-MONAI:devfrom
mingxin-zheng:fix-6456
May 2, 2023
Merged

Auto3DSeg ensemble tests images depend on #GPUs + docstring improvement#6457
wyli merged 8 commits intoProject-MONAI:devfrom
mingxin-zheng:fix-6456

Conversation

@mingxin-zheng
Copy link
Copy Markdown
Contributor

@mingxin-zheng mingxin-zheng commented May 2, 2023

Fixes #6456.

Description

  • Make the test images also depend on GPUs
  • Improve docstring for infer

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
Copy link
Copy Markdown
Contributor Author

Hi @wyli , I have a naive question:

There was some docstring to show to use the __call__ method since MONAI 1.0 in

Use the ensembled model to predict result.

But I can't find those in https://docs.monai.io/en/stable/apps.html#module-monai.apps.auto3dseg. Do you know why it is missing? Thanks!

@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 2, 2023

yes, currently the special members are hidden by default, it's possible to enable them like this one

:members:
:special-members: __call__

@mingxin-zheng
Copy link
Copy Markdown
Contributor Author

Thanks @wyli . I will try to set them visible then

@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 2, 2023

/build

Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 2, 2023

/build

@wyli wyli enabled auto-merge (squash) May 2, 2023 13:44
@wyli wyli merged commit 4bfc8e9 into Project-MONAI:dev May 2, 2023
@mingxin-zheng mingxin-zheng deleted the fix-6456 branch May 10, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto3DSeg tests improvement on mGPU ensemble

2 participants