Skip to content

Improve nnunet documentations, removed wrong mGPU usage, and fix work_dir#6448

Merged
wyli merged 17 commits intoProject-MONAI:devfrom
mingxin-zheng:fix-6443
May 4, 2023
Merged

Improve nnunet documentations, removed wrong mGPU usage, and fix work_dir#6448
wyli merged 17 commits intoProject-MONAI:devfrom
mingxin-zheng:fix-6443

Conversation

@mingxin-zheng
Copy link
Copy Markdown
Contributor

@mingxin-zheng mingxin-zheng commented Apr 28, 2023 •
edited by wyli
Loading

Fixes #6447
Fixes #6443

Description

  • Put the documentation together
  • Add missing docstring
  • num_gpus is not the right way to do mGPU training
  • improve logging (no more logging.warning("[info] ..."))
  • fix work_dir

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@mingxin-zheng
Remove invalid nnunet argument and fix documentation
62da773 
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
fix flake8
f71b1c6 
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
revert removing gpu_id
c5551b7 
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
fix more methods
aa087b8 
Signed-off-by: Mingxin Zheng <[email protected]>
pre-commit-ci bot and others added 10 commits April 28, 2023 04:35
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b924acc 
for more information, see https://pre-commit.ci
@mingxin-zheng
Add missing docstring
8e1b30f 
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
Merge branch 'fix-6443' of https://github.com/mingxin-zheng/MONAI int…
428f713 
…o fix-6443

Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
fix multigpu example
647fbdc 
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
fix input_config
e6f4a01 
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
add docstring
4ef5f23 
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
fix indent
2fc4826 
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
log
cdca072 
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
fix typo
f535f8b 
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
true -> True
f8910d5 
Signed-off-by: Mingxin Zheng <[email protected]>
dongyang0122
dongyang0122 reviewed May 1, 2023
View reviewed changes
@mingxin-zheng
fix comments
4a7136a 
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
fix comments
9af2d74 
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng mingxin-zheng requested review from Nic-Ma and wyli May 4, 2023 03:00
wyli
wyli reviewed May 4, 2023
View reviewed changes
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 4, 2023

/build

@wyli wyli enabled auto-merge (squash) May 4, 2023 05:51
@wyli wyli disabled auto-merge May 4, 2023 06:17
@wyli wyli enabled auto-merge (squash) May 4, 2023 06:17
@wyli wyli merged commit 8e8dd1b into Project-MONAI:dev May 4, 2023
@mingxin-zheng mingxin-zheng deleted the fix-6443 branch May 10, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@dongyang0122 dongyang0122 dongyang0122 left review comments

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

work_dir is not effective when running trainin monai.apps.nnunet Documentation of nnUNet in monai.apps has several mistakes

3 participants

@mingxin-zheng @wyli @dongyang0122