Fix for zoom used in a lazy pipeline#6437
Merged
wyli merged 3 commits intoProject-MONAI:devfrom Apr 26, 2023
Merged
Conversation
Signed-off-by: Ben Murray <[email protected]>
Signed-off-by: Ben Murray <[email protected]>
Contributor
Author
|
Incidental bug noticed while prepping #6257 |
Signed-off-by: Ben Murray <[email protected]>
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you run the following pipeline with lazy resampling it breaks as the pending info contains a 3x3 affine transform and there are 4x4 affine transforms already in the list:
Although it could be fixed by ensuring that Zoom always puts out a 4x4 affine, the more flexible and pragmatic solution is to promote 2d affine transforms to 3d affine transforms as a matter of course. This way we never have the issue that a given transform (particularly potential 3rd party transforms modified for lazy execution) can subsequently cause this problem.
Description
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.