Make Auto3DSeg algo able to find algorithm templates#6436
Merged
wyli merged 17 commits intoProject-MONAI:devfrom Apr 27, 2023
mingxin-zheng:fix-6435
Merged
Make Auto3DSeg algo able to find algorithm templates#6436wyli merged 17 commits intoProject-MONAI:devfrom mingxin-zheng:fix-6435
wyli merged 17 commits intoProject-MONAI:devfrom
mingxin-zheng:fix-6435
Conversation
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Contributor
Author
|
/integration-test |
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
wyli
approved these changes
Apr 26, 2023
Contributor
Author
|
I found some deprecated documentations in AutoRunner about "CUDA_VISIBLE_DEVICES" usage. Removing them in this PR as well. |
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Contributor
Author
|
Since |
Contributor
|
/build |
5 tasks
wyli
pushed a commit
that referenced
this pull request
May 10, 2023
…templates folder (#6505) Fixes #6502 Fixes #6501 ### Background - BundleAlgo `template_path` points to `algorithm_templates/<Algo>` <= MONAI 1.1. Recent PR #6436 changed that to `algorithm_templates` and make it easier to instantiate the BundleAlgo from "algorithm_templates" folder when the folders are moved. - But `BundleGen` did not update accordingly and still save `algorithm_templates/<Algo>` as the `template_path` , which breaks NNI HPO feature which relies heavily on these paths. ### Description - Make `template_path` points to `algorithm_templates` - Avoid using the latest `filelock` (3.12.0) which breaks nni - Fix comments in #6485 (comment) in #6485 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] New tests added to cover the changes. - [x] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. --------- Signed-off-by: Mingxin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6435 .
Description
In this PR, the changes are
template_patha property that's available for all Algo classes to find the path to instantiate the class. The default value oftemplate_pathis None.algo_from_picklefunction by making it search in a few candidate directories to instantiate theAlgoclass if needed.BundleAlgoin HPO logics becausetemplate_pathis universal for allAlgonow.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.