Skip to content

Fix ensemble output using RankFilter and minor rename#6434

Merged
wyli merged 3 commits intoProject-MONAI:devfrom
mingxin-zheng:fix-6433
Apr 26, 2023
Merged

Fix ensemble output using RankFilter and minor rename#6434
wyli merged 3 commits intoProject-MONAI:devfrom
mingxin-zheng:fix-6433

Conversation

@mingxin-zheng
Copy link
Copy Markdown
Contributor

@mingxin-zheng mingxin-zheng commented Apr 26, 2023

Fixes #6433 .

also fixes #6338

Description

  • Move the SaveImage Transform setters back to ensemble method to ensure DDP is initiated
  • Use RankFilter to suppress logging for rank >0
  • Minor updates such as renaming and tests

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Apr 26, 2023

/integration-test
/build

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Apr 26, 2023

/build

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Apr 26, 2023

/build

@wyli wyli enabled auto-merge (squash) April 26, 2023 10:39
@wyli wyli merged commit b42164f into Project-MONAI:dev Apr 26, 2023
@mingxin-zheng mingxin-zheng deleted the fix-6433 branch May 10, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicated logging messages in the call of the ensemble method in EnsembleRunner remove deprecated 'by_case' in data analyzer .yaml output

2 participants