Skip to content

6424 Add support to register customized app required properties#6432

Merged
Nic-Ma merged 19 commits intoProject-MONAI:devfrom
Nic-Ma:6424-register-property
Apr 28, 2023
Merged

6424 Add support to register customized app required properties#6432
Nic-Ma merged 19 commits intoProject-MONAI:devfrom
Nic-Ma:6424-register-property

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Apr 26, 2023

Fixes #6424 .

Description

This PR added support to register customized app required properties to the BundleWorkflow, then check and access the properties.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 28, 2023

/black

@Nic-Ma Nic-Ma changed the title [WIP] 6424 Add support to register customized app required properties 6424 Add support to register customized app required properties Apr 28, 2023
@Nic-Ma Nic-Ma marked this pull request as ready for review April 28, 2023 14:53
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 28, 2023

/build

Copy link
Copy Markdown
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with it, thanks!

Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 28, 2023

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 28, 2023

/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance BundleWorkflow properties and the operations

4 participants