6426 warn when inverting lazy + non-lazy-invertible transforms#6428
Merged
wyli merged 1 commit intoProject-MONAI:devfrom Apr 25, 2023
Merged
6426 warn when inverting lazy + non-lazy-invertible transforms#6428wyli merged 1 commit intoProject-MONAI:devfrom
wyli merged 1 commit intoProject-MONAI:devfrom
Conversation
Signed-off-by: Wenqi Li <[email protected]>
KumoLiu
approved these changes
Apr 25, 2023
ericspod
approved these changes
Apr 25, 2023
ericspod
reviewed
Apr 25, 2023
Member
ericspod
left a comment
ericspod
left a comment
There was a problem hiding this comment.
Actually @atbenmurray would like to review.
atbenmurray
reviewed
Apr 25, 2023
Contributor
atbenmurray
left a comment
atbenmurray
left a comment
There was a problem hiding this comment.
#6257 Fixes the issue that required this special case code. I don't think that in the general case it should be possible to end up with pending transforms if you have used compose. Is this change (and the underlying warning) actually still necessary?
Contributor
Author
|
yes, it's necessary to warn the user defined transforms |
Contributor
Author
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6426
Description
only warn when checking the most recent applied operations
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.