Skip to content

Fix Ensemble dir creation bug in multi-GPU testing cases#6422

Merged
wyli merged 9 commits intoProject-MONAI:devfrom
mingxin-zheng:fix-6417
Apr 23, 2023
Merged

Fix Ensemble dir creation bug in multi-GPU testing cases#6422
wyli merged 9 commits intoProject-MONAI:devfrom
mingxin-zheng:fix-6417

Conversation

@mingxin-zheng
Copy link
Copy Markdown
Contributor

@mingxin-zheng mingxin-zheng commented Apr 23, 2023

Fixes #6417 .

Description

  • Move the logics of creating ensemble output dir from ensemble to __init__ in EnsembleRunner to avoid processes competing with each other in dir creation
  • Add checks in AutoRunner set_image_save_transform

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
Copy link
Copy Markdown
Contributor Author

/integration-test

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Apr 23, 2023

/build

1 similar comment
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Apr 23, 2023

/build

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Apr 23, 2023

/build

@wyli wyli enabled auto-merge (squash) April 23, 2023 19:35
@wyli wyli merged commit 9c97777 into Project-MONAI:dev Apr 23, 2023
@mingxin-zheng mingxin-zheng deleted the fix-6417 branch April 24, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto3dseg integration

2 participants