Skip to content

Adjust the args order of MonaiAlgo#6418

Merged
wyli merged 10 commits intoProject-MONAI:devfrom
Nic-Ma:adjust-fl-args
Apr 22, 2023
Merged

Adjust the args order of MonaiAlgo#6418
wyli merged 10 commits intoProject-MONAI:devfrom
Nic-Ma:adjust-fl-args

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Apr 22, 2023

Description

According to the discussion with @holgerroth and @wyli , to make the args of MonaiAlgo more clear, this PR adjusted the order. In the future versions, we will simplify to only use TrainWorflow and EvalWorkflow and deprecate bundle related args.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 22, 2023

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 22, 2023

/build

@Nic-Ma Nic-Ma requested review from holgerroth and wyli April 22, 2023 15:04
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Apr 22, 2023

/build

@wyli wyli enabled auto-merge (squash) April 22, 2023 19:16
@wyli wyli merged commit 9a5b900 into Project-MONAI:dev Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants