Skip to content

5903 Add support to set MLFlow run_name in MonaiAlgo#6413

Merged
Nic-Ma merged 13 commits intoProject-MONAI:devfrom
Nic-Ma:5903-add-fl-runname
Apr 22, 2023
Merged

5903 Add support to set MLFlow run_name in MonaiAlgo#6413
Nic-Ma merged 13 commits intoProject-MONAI:devfrom
Nic-Ma:5903-add-fl-runname

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Apr 21, 2023

Fixes #5903 .

Description

This PR added support to automatically set MLFlow run_name in the MonaiAlgo.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma requested review from binliunls, holgerroth and wyli April 21, 2023 11:42
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 21, 2023

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 21, 2023

/build

Copy link
Copy Markdown
Collaborator

@holgerroth holgerroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change. Confirmed with nvflare 2.3.0

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 21, 2023

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 21, 2023

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) April 21, 2023 17:25
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 21, 2023

Hi @wyli ,

Do you have any other comments?

Thanks in advance.

@Nic-Ma Nic-Ma disabled auto-merge April 21, 2023 22:48
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 21, 2023

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 21, 2023

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) April 21, 2023 23:12
@Nic-Ma Nic-Ma merged commit e3977dd into Project-MONAI:dev Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Experiment tracking with MonaiAlgo

3 participants