Skip to content

6404 inverse lazy crop foreground#6405

Merged
wyli merged 9 commits intoProject-MONAI:devfrom
wyli:fixes-cropforeground
Apr 20, 2023
Merged

6404 inverse lazy crop foreground#6405
wyli merged 9 commits intoProject-MONAI:devfrom
wyli:fixes-cropforeground

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Apr 20, 2023

Fixes #6404

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested a review from KumoLiu April 20, 2023 13:37
@wyli wyli marked this pull request as ready for review April 20, 2023 13:41
@wyli
assert empty stack
3a1e9e5 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Apr 20, 2023

/build

KumoLiu
KumoLiu approved these changes Apr 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for update.

@wyli wyli force-pushed the fixes-cropforeground branch from 7980454 to 0c1d3cc Compare April 20, 2023 15:28
@wyli
more tests
75c75e4 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the fixes-cropforeground branch from 0c1d3cc to 75c75e4 Compare April 20, 2023 15:42
wyli added 2 commits April 20, 2023 19:27
@wyli
default lazy transform info
f5921d9 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
update
59c588f 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli enabled auto-merge (squash) April 20, 2023 18:45
wyli added 3 commits April 20, 2023 19:56
@wyli
update
1dedaa5 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
copy
fe82086 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
fixes tests
40f7ca5 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Apr 20, 2023 •
edited
Loading

/integration-test

@wyli
fixes test case
5311012 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Apr 20, 2023

/build

@wyli wyli merged commit fbf8847 into Project-MONAI:dev Apr 20, 2023
@wyli wyli deleted the fixes-cropforeground branch May 10, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KumoLiu KumoLiu KumoLiu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

inverse lazily applied cropforeground with k_divisible>1

2 participants

@wyli @KumoLiu