Skip to content

enable TensorRT for detection by adding support of list output for RetinaNet #6393

Merged
wyli merged 34 commits intoProject-MONAI:devfrom
Can-Zhao:detection_output
Apr 21, 2023
Merged

enable TensorRT for detection by adding support of list output for RetinaNet #6393
wyli merged 34 commits intoProject-MONAI:devfrom
Can-Zhao:detection_output

Conversation

@Can-Zhao
Copy link
Copy Markdown
Collaborator

@Can-Zhao Can-Zhao commented Apr 18, 2023 •
edited
Loading

Fixes #6330 .

Description

add support of list for retinanet

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma requested a review from binliunls April 19, 2023 04:56
binliunls
binliunls reviewed Apr 19, 2023
View reviewed changes
binliunls
binliunls reviewed Apr 19, 2023
View reviewed changes
@Can-Zhao Can-Zhao changed the title add support of namedtuple for retinanet add support of tuple output for RetinaNet Apr 20, 2023
Can-Zhao and others added 10 commits April 20, 2023 10:54
@Can-Zhao
Merge branch 'dev' into detection_output
27a3e95
@Can-Zhao
update comment
44749ae 
Signed-off-by: Can-Zhao <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
fc21be4 
for more information, see https://pre-commit.ci
@Can-Zhao
let detector input the attributes
d2d76ac 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
Merge branch 'detection_output' of github.com:Can-Zhao/MONAI into det…
f81e312 
…ection_output
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
62b7dda 
for more information, see https://pre-commit.ci
@Can-Zhao
let detector input the attributes
820a05c 
Signed-off-by: Can-Zhao <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
61e863a 
for more information, see https://pre-commit.ci
@Can-Zhao
update comments
7be84c0 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
Merge branch 'detection_output' of github.com:Can-Zhao/MONAI into det…
16ea201 
…ection_output
@Can-Zhao Can-Zhao changed the title add support of tuple output for RetinaNet enable tensorRT for detection by adding support of tuple output for RetinaNet Apr 20, 2023
@Can-Zhao Can-Zhao changed the title enable tensorRT for detection by adding support of tuple output for RetinaNet enable TensorRT for detection by adding support of tuple output for RetinaNet Apr 20, 2023
@Can-Zhao Can-Zhao changed the title enable TensorRT for detection by adding support of tuple output for RetinaNet enable TensorRT for detection by adding support of list output for RetinaNet Apr 20, 2023
@Can-Zhao Can-Zhao marked this pull request as ready for review April 20, 2023 23:48
binliunls
binliunls reviewed Apr 21, 2023
View reviewed changes
@binliunls
Copy link
Copy Markdown
Contributor

binliunls commented Apr 21, 2023

Hi @Can-Zhao ,
Looks good to me. @Nic-Ma , could you please take a look at this PR?

Thanks,
Bin

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Apr 21, 2023

/build

Nic-Ma
Nic-Ma approved these changes Apr 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @wyli do you have any other comments from research network angle?

Thanks in advance.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Apr 21, 2023

looks good to me, I guess we'll have more integration tests about the trt from the model zoo?

@wyli wyli enabled auto-merge (squash) April 21, 2023 11:09
@wyli wyli merged commit 4404075 into Project-MONAI:dev Apr 21, 2023
@Can-Zhao Can-Zhao deleted the detection_output branch April 21, 2023 15:36
@binliunls binliunls mentioned this pull request Aug 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@binliunls binliunls binliunls approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot run the lung_nodule_ct_detection TensorRT model end-to-end

4 participants

@Can-Zhao @binliunls @wyli @Nic-Ma