Skip to content

int -> float type annotation for LRFinder#6364

Merged
wyli merged 1 commit intoProject-MONAI:devfrom
joshestein:6363-LR-type-annotation
Apr 14, 2023
Merged

int -> float type annotation for LRFinder#6364
wyli merged 1 commit intoProject-MONAI:devfrom
joshestein:6363-LR-type-annotation

Conversation

@joshestein
Copy link
Copy Markdown
Contributor

@joshestein joshestein commented Apr 14, 2023

Fixes #6363.

Description

Correct type annotation for end_lr.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Apr 14, 2023

thanks @joshestein, could you please sign-off https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#signing-your-work

@joshestein
Copy link
Copy Markdown
Contributor Author

Apologies, have signed-off 👍

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Apr 14, 2023

/build

@wyli wyli marked this pull request as ready for review April 14, 2023 17:24
@wyli wyli enabled auto-merge (squash) April 14, 2023 17:24
@wyli wyli merged commit 7bb74c6 into Project-MONAI:dev Apr 14, 2023
@joshestein joshestein deleted the 6363-LR-type-annotation branch April 15, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LRFinder range_test has incorrect type annotation for end_lr

2 participants