Skip to content

6340 update dtype for lazy resampling#6341

Merged
wyli merged 4 commits intoProject-MONAI:temp-mergefrom
wyli:6340-lazy-resample-dtype
Apr 12, 2023
Merged

6340 update dtype for lazy resampling#6341
wyli merged 4 commits intoProject-MONAI:temp-mergefrom
wyli:6340-lazy-resample-dtype

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Apr 12, 2023

Fixes #6340
Fixes #6253

Description

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 3 commits April 12, 2023 01:12
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 6340-lazy-resample-dtype branch from 46e52b1 to cb86d73 Compare April 12, 2023 00:33
@wyli wyli requested review from KumoLiu and Nic-Ma April 12, 2023 00:33
@wyli wyli marked this pull request as ready for review April 12, 2023 00:34
@wyli wyli changed the title update dtype for lazy resampling 6340 update dtype for lazy resampling Apr 12, 2023
@wyli wyli changed the base branch from dev to temp-merge April 12, 2023 06:59
@wyli wyli merged commit 1ed59df into Project-MONAI:temp-merge Apr 12, 2023
@wyli wyli mentioned this pull request Apr 12, 2023
7 tasks
wyli added a commit that referenced this pull request Apr 12, 2023
closes #6339 (closes #6337)
closes #6341 (closes #6340 closes #6253)


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: binliu <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Co-authored-by: binliunls <[email protected]>
wyli added a commit that referenced this pull request Apr 12, 2023
Signed-off-by: monai-bot <[email protected]>

closes #6339 (closes #6337)
closes #6341 (closes #6340 closes #6253)
closes #6345 
closes #6247 (closes #6346)

---------

Signed-off-by: monai-bot <[email protected]>
Signed-off-by: binliu <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Co-authored-by: Wenqi Li <[email protected]>
Co-authored-by: binliunls <[email protected]>
Co-authored-by: Wenqi Li <[email protected]>
Co-authored-by: Mingxin Zheng <[email protected]>
@wyli wyli deleted the 6340-lazy-resample-dtype branch May 17, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lazy.utils.resample output dtype Early versions of isort incompatibility

3 participants