Bug-fix in AlgoEnsembleBestN and AlgoEnsembleBestbyFold#6300
Merged
wyli merged 3 commits intoProject-MONAI:devfrom Apr 6, 2023
Merged
Bug-fix in AlgoEnsembleBestN and AlgoEnsembleBestbyFold#6300wyli merged 3 commits intoProject-MONAI:devfrom
wyli merged 3 commits intoProject-MONAI:devfrom
Conversation
Collaborator
|
This looks great to me. @ValentinaVisani thank you for finding and fixing both bugs (which were not very obvious)! And congrats on your first issue and PR! @wyli let's merge. I may later simplify our code in AlgoEnsembleBestN, which looks too convoluted for that simple task. |
myron
approved these changes
Apr 6, 2023
Contributor
|
/build |
Contributor
|
/integration-test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To solve: #6299
Description
You can find the description of the changes in issue #6299