Closed
Conversation
This reverts commit 9b09ed6.
Member
|
Hi @wyli, I see this and another PR reverting previous ones, what is the issue here? |
Contributor
Author
Member
|
OK thanks @wyli, we can always re-revert these changes once we know the issue and we won't lose this work. |
Contributor
|
Hi @wyli , there is a DCO ci error currently. Could I directly commit on this PR and ignore this error? Thanks, |
Contributor
|
Hi @liqunfu , Thank, |
Contributor
7 tasks
Contributor
|
thanks @binliunls for pointing out the legacy of example_outputs! |
wyli
pushed a commit
that referenced
this pull request
Apr 6, 2023
…6309) Fixes # . #6297 ### Description PyTorch onnx exporter API has been changed since 1.10 to remove example_outputs as a required input argument. Special handling is added in this PR to support PyTorch version older than 1.10. Unit test is also extended to covert this case. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Liqun Fu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6237