Skip to content

SlidingWindowInfererAdapt#6251

Merged
wyli merged 6 commits intoProject-MONAI:devfrom
myron:sliding
Apr 14, 2023
Merged

SlidingWindowInfererAdapt#6251
wyli merged 6 commits intoProject-MONAI:devfrom
myron:sliding

Conversation

@myron
Copy link
Copy Markdown
Collaborator

@myron myron commented Mar 27, 2023 •
edited by wyli
Loading

SlidingWindowInfererAdapt extends SlidingWindowInferer to automatically switch to buffered and then to CPU stitching, when OOM on GPU. It also records a size of such large images to automatically try CPU stitching for the next large image of a similar size. If the stitching 'device' input parameter is provided,
automatic adaptation won't be attempted, please keep the default option device = None for adaptive behavior.
Note: the output might be on CPU (even if the input was on GPU), if the GPU memory was not sufficient.

also fixes #6340 by adding one line to the resampling

@myron myron added the enhancement New feature or request label Mar 27, 2023
@myron myron added this to the Auto3DSeg enhancement [P0 v1.2] milestone Mar 27, 2023
@myron myron requested a review from wyli March 27, 2023 22:29
@myron
Copy link
Copy Markdown
Collaborator Author

myron commented Mar 27, 2023

I'm not sure why it fails premerge/flake test. It's fine for me. can someone help plz @mingxin-zheng @wyli

@mingxin-zheng
Copy link
Copy Markdown
Contributor

mingxin-zheng commented Mar 28, 2023 •
edited
Loading

Hi @myron , as I replied in the slack channel, this could be caused by using a different version of isort.

I ran ./runtests --autofix and it shows the line 623 and 630 should be removed in monai/inferers/inferer.py

wyli
wyli reviewed Mar 28, 2023
View reviewed changes
myron
myron commented Mar 29, 2023
View reviewed changes
myron
myron commented Mar 29, 2023
View reviewed changes
myron
myron commented Mar 29, 2023
View reviewed changes
@wyli wyli marked this pull request as draft March 30, 2023 14:17
@myron myron marked this pull request as ready for review April 14, 2023 02:25
myron added 3 commits April 13, 2023 19:34
@myron
<=
83ea09c 
Signed-off-by: myron <[email protected]>
@myron
thresh
25e6ab6 
Signed-off-by: myron <[email protected]>
@myron
type:ignore
5bc7459 
Signed-off-by: myron <[email protected]>
@myron
Copy link
Copy Markdown
Collaborator Author

myron commented Apr 14, 2023

@wyli I've updated this PR to include buffered case handling, please check and merge

also mypy complained on the super().call_() lines with error:

mypy
mypy 1.2.0 (compiled: yes)
monai/inferers/inferer.py:509:20: error: "__call__" of "SlidingWindowInferer" gets multiple values for keyword argument "inputs"  [misc]
monai/inferers/inferer.py:509:20: error: "__call__" of "SlidingWindowInferer" gets multiple values for keyword argument "network"  [misc]
monai/inferers/inferer.py:519:23: error: "__call__" of "SlidingWindowInferer" gets multiple values for keyword argument "inputs"  [misc]
monai/inferers/inferer.py:519:23: error: "__call__" of "SlidingWindowInferer" gets multiple values for keyword argument "network"  [misc]

even though, the code looks correct.
I added "type:ignore" , because I couldn't figure it out, may be there is better way.

wyli
wyli approved these changes Apr 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I'll test and merge it soon

wyli added 2 commits April 14, 2023 02:27
@wyli
adds tests
e1679a7 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
fixes #6340
a9a9562 
Signed-off-by: Wenqi Li <[email protected]>
wyli
wyli reviewed Apr 14, 2023
View reviewed changes
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Apr 14, 2023

/build

@wyli wyli enabled auto-merge (squash) April 14, 2023 06:40
@wyli wyli merged commit 3633b1c into Project-MONAI:dev Apr 14, 2023
@wyli wyli mentioned this pull request Apr 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@mingxin-zheng mingxin-zheng mingxin-zheng left review comments

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

Auto3DSeg enhancement [P0 v1.2]

Development

Successfully merging this pull request may close these issues.

lazy.utils.resample output dtype

3 participants

@myron @mingxin-zheng @wyli