Skip to content

Enable algorithm skip in bundle_gen#6239

Merged
wyli merged 7 commits intoProject-MONAI:devfrom
heyufan1995:skip2d
Apr 5, 2023
Merged

Enable algorithm skip in bundle_gen#6239
wyli merged 7 commits intoProject-MONAI:devfrom
heyufan1995:skip2d

Conversation

@heyufan1995
Copy link
Copy Markdown
Member

Fixes #6184 .

Description

Enable bundlle_gen to skip an algorithm if the BundleAlgo pre_check_skip_algo() function sets skip_bundlegen=True. SegResNet2D overrided pre_check_skip_algo() and will be skipped if data is not highly anisotropic.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 26, 2023

/black

@mingxin-zheng
Copy link
Copy Markdown
Contributor

Thank you @heyufan1995 for the PR.

I think it would be better to set the skip_bundlegen 's default value in the init function too.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Apr 5, 2023

/black

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Apr 5, 2023

/integration-test
/build

@wyli wyli enabled auto-merge (squash) April 5, 2023 19:37
@wyli wyli merged commit d5258cc into Project-MONAI:dev Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Skip 2D/3D training if the data slice thickness are highly anisotropic

5 participants