Skip to content

Fix "fast_training_tutorial.ipynb"#6150

Merged
wyli merged 9 commits intoProject-MONAI:devfrom
KumoLiu:fix-sliding-window-inference
Mar 15, 2023
Merged

Fix "fast_training_tutorial.ipynb"#6150
wyli merged 9 commits intoProject-MONAI:devfrom
KumoLiu:fix-sliding-window-inference

Conversation

@KumoLiu
Copy link
Copy Markdown
Contributor

@KumoLiu KumoLiu commented Mar 15, 2023 •
edited by wyli
Loading

Fixes Project-MONAI/tutorials#1250.
Fixes #6149

Description

Now when Resize accept the same spatial_size with the original shape and set_track_meta(False), it will only return meta information.

MONAI/monai/transforms/spatial/functional.py

Lines 297 to 301 in 9fd6d4c

out = convert_to_tensor(img.as_tensor() if isinstance(img, MetaTensor) else img, track_meta=get_track_meta())
if transform_info.get(TraceKeys.LAZY_EVALUATION, False) or tuple(convert_to_numpy(orig_size)) == out_size:
if anti_aliasing and transform_info.get(TraceKeys.LAZY_EVALUATION, False):
warnings.warn("anti-aliasing is not compatible with lazy evaluation.")
return out.copy_meta_from(meta_info) if isinstance(out, MetaTensor) else meta_info

In fast_training_tutorial.ipynb, when in "fast" mode, it will set_track_meta(False) which causes error when doing Resize
This pr change sliding_window_inference to only Resize when the shape is different.

MONAI/monai/inferers/utils.py

Line 253 in a2ec375

importance_map_zoom = resizer(importance_map.unsqueeze(0))[0].to(compute_dtype)

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli and others added 3 commits March 15, 2023 08:51
@wyli
update threshold
1512d43 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
update threshold
36f2431 
Signed-off-by: Wenqi Li <[email protected]>
@KumoLiu
fix tutorials Project-MONAI#1250
4aa5493 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu KumoLiu requested review from Nic-Ma and wyli March 15, 2023 09:53
wyli
wyli reviewed Mar 15, 2023
View reviewed changes
KumoLiu and others added 2 commits March 15, 2023 18:28
@KumoLiu
fix Resize when shape not change
725b7ca 
Signed-off-by: KumoLiu <[email protected]>
@wyli
tests
86363fc 
Signed-off-by: Wenqi Li <[email protected]>
wyli
wyli approved these changes Mar 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me. I'll include minor integration tests dev...6149-integraion

wyli
wyli reviewed Mar 15, 2023
View reviewed changes
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 15, 2023

/build

@wyli wyli enabled auto-merge (squash) March 15, 2023 13:10
@wyli wyli disabled auto-merge March 15, 2023 13:18
@wyli wyli merged commit 778d0aa into Project-MONAI:dev Mar 15, 2023
@KumoLiu KumoLiu deleted the fix-sliding-window-inference branch March 16, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

integration errors fast_training_tutorial.ipynb

2 participants

@KumoLiu @wyli