Skip to content

DataAnalyzer enhancements#6131

Merged
wyli merged 9 commits intoProject-MONAI:devfrom
myron:stats
Mar 16, 2023
Merged

DataAnalyzer enhancements#6131
wyli merged 9 commits intoProject-MONAI:devfrom
myron:stats

Conversation

@myron
Copy link
Copy Markdown
Collaborator

@myron myron commented Mar 11, 2023

Adds several improvements to DataAnalyzer, including

  • Calculates image sizes in mm and their summaries (in additional to shapes and spacing)
  • Saves the datastats.yaml file as 2 files, the summary and the statistics by case. The datastats.yaml will have only summaries, to be able to load it faster. Otherwise for a large datasets (with many labels) YAML loading takes over 2minutes.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

myron added 2 commits March 10, 2023 19:19
Signed-off-by: myron <[email protected]>
@myron myron added the enhancement New feature or request label Mar 11, 2023
@myron myron added this to the Auto3DSeg enhancement [P0 v1.2] milestone Mar 11, 2023
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I added a few lines to fix the typing error monai/apps/auto3dseg/transforms.py:64:26: error: "Tensor" has no attribute "meta" [attr-defined]

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 11, 2023

/build

@wyli wyli enabled auto-merge (squash) March 11, 2023 13:08
@wyli wyli disabled auto-merge March 11, 2023 14:10
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 13, 2023

/build

@wyli wyli enabled auto-merge (squash) March 13, 2023 22:45
@wyli wyli disabled auto-merge March 14, 2023 10:21
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 16, 2023

/build

@wyli wyli enabled auto-merge (squash) March 16, 2023 06:48
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 16, 2023

/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants