Skip to content

add remaining crop transforms with unit tests for lazy resampling#6083

Merged
wyli merged 24 commits intoProject-MONAI:devfrom
KumoLiu:crop-lazy-rand
Mar 1, 2023
Merged

add remaining crop transforms with unit tests for lazy resampling#6083
wyli merged 24 commits intoProject-MONAI:devfrom
KumoLiu:crop-lazy-rand

Conversation

@KumoLiu
Copy link
Copy Markdown
Contributor

@KumoLiu KumoLiu commented Mar 1, 2023

Part of #5991

Description

This PR adds the remaining crop transforms from #5860 relate to lazy resampling, and it belongs to the second part mentioned in #5991

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

and `RandCropByPosNegLabel`

Signed-off-by: KumoLiu <[email protected]>
@KumoLiu KumoLiu marked this pull request as ready for review March 1, 2023 09:49
@KumoLiu KumoLiu changed the title [WIP] add remaining crop transforms with unit tests for lazy resampling add remaining crop transforms with unit tests for lazy resampling Mar 1, 2023
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 1, 2023

/build

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, merging for more benchmarking in terms of the new lazy_evaluation=False crop/pad, please follow up @Nic-Ma @yiheng-wang-nv if you have any concerns.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 1, 2023

/build

@wyli wyli enabled auto-merge (squash) March 1, 2023 18:01
@wyli wyli merged commit 7baf282 into Project-MONAI:dev Mar 1, 2023
@KumoLiu KumoLiu deleted the crop-lazy-rand branch March 9, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants