Skip to content

add crop transforms with unit tests for lazy resampling#6068

Merged
wyli merged 20 commits intoProject-MONAI:devfrom
KumoLiu:crop-lazy
Feb 28, 2023
Merged

add crop transforms with unit tests for lazy resampling#6068
wyli merged 20 commits intoProject-MONAI:devfrom
KumoLiu:crop-lazy

Conversation

@KumoLiu
Copy link
Copy Markdown
Contributor

@KumoLiu KumoLiu commented Feb 27, 2023

Part of #5991 .

Description

This PR adds the crop transforms from #5860 relate to lazy resampling, and it belongs to the second part mentioned in #5991

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

KumoLiu added 10 commits February 24, 2023 14:20
KumoLiu
KumoLiu commented Feb 27, 2023
View reviewed changes
KumoLiu
KumoLiu commented Feb 27, 2023
View reviewed changes
@KumoLiu
Copy link
Copy Markdown
Contributor Author

KumoLiu commented Feb 27, 2023

Just set this PR to be ready for review. And will create another pr for CropForeground and other random crop transforms to avoid large PR.

@KumoLiu KumoLiu marked this pull request as ready for review February 27, 2023 16:34
@KumoLiu KumoLiu changed the title [WIP] add crop transforms with unit tests for lazy resampling add crop transforms with unit tests for lazy resampling Feb 27, 2023
Nic-Ma
Nic-Ma approved these changes Feb 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, put some minor coments inline.

Thanks.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Feb 28, 2023

/build

@wyli wyli enabled auto-merge (squash) February 28, 2023 09:40
@wyli wyli disabled auto-merge February 28, 2023 09:59
@wyli
fixes docs warnings
fd14162 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Feb 28, 2023

/build

@wyli wyli enabled auto-merge (squash) February 28, 2023 10:46
@wyli wyli mentioned this pull request Feb 28, 2023
Closed
11 tasks
@wyli wyli merged commit c2fc083 into Project-MONAI:dev Feb 28, 2023
@KumoLiu KumoLiu deleted the crop-lazy branch March 1, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KumoLiu @wyli @Nic-Ma